https://bugzilla.redhat.com/show_bug.cgi?id=2122022 Akira TAGOH <tagoh@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tagoh@xxxxxxxxxx --- Comment #1 from Akira TAGOH <tagoh@xxxxxxxxxx> --- Before starting the formal review: 1. the foundry is supposed to be set from the foundry property in fontconfig though, "PfEd" is too generic. if upstream doesn't have too much fonts shipped by them, you can simply omit that field. or if "Terminus" is a unique name enough, you can use it instead, like DejaVu. 2. please set correct family name to the family. that should be "Terminus (TTF)". this affects the AppStream file and the wrong name there makes harder to find out the exact font name through AppStream. 3. You don't need "<test name="lang"...><string>en</string>" thing in config. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2122022 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
