https://bugzilla.redhat.com/show_bug.cgi?id=1684603 --- Comment #13 from Jaroslav Škarvada <jskarvad@xxxxxxxxxx> --- Thanks for the review. > Initial Comments: > a) See Python packaging guidelines, > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python_201x/ > consider naming slightly differently https://docs.fedoraproject.org/en-US/packaging-guidelines/Python_201x/#_naming "This rule does not apply to applications." > b) Builds on all architectures: > https://copr.fedorainfracloud.org/coprs/fed500/bCNC/build/4944630/ What's wrong? It seems it builds OK. > c) Installation failure likely due to the issue > https://bugzilla.redhat.com/show_bug.cgi?id=2132574 Probably nothing to fix here on our side. > d) Tests are included in the software, can they be run? I will check. > e) Newer tag is available, perhaps this can be packaged? One of the tags is I will check, it's quite long time this review request was submitted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=1684603 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
