[Bug 2134021] Review Request: mingw-pyproject-rpm-macros - RPM macros for PEP 517 MinGW Python packages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2134021

Petr Viktorin <pviktori@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pviktori@xxxxxxxxxx



--- Comment #16 from Petr Viktorin <pviktori@xxxxxxxxxx> ---
> python-build also requires python-pep517 which unconditionally requires tomli

Not in Rawhide (0.13.0 upstream). Do you need that backported?

> any tips on the best practice to install the wheel to the buildroot?

With python3-installer. (Or pip, which pyproject-rpm-macros still does.)

If you don't have python3-pip or python3-installer yet, you could unzip a
wheel.
The spec is here:
https://packaging.python.org/en/latest/specifications/binary-distribution-format/#details
By simply unzipping, you will miss:
- Version check for the wheel format
- Spreading files from a top-level *.data directory (e.g. scripts that should
go to /usr/bin)
- byte-compilation, which fully-bootstrapped RPM macros should do for you
- removing the *.dist-info/RECORD file (which you have to do even after
installing with pip/installer)

So it's best to only use this to bootstrap an installer.

Another possibility might be to run pip directly from its wheel. This does not
work in general [0], but pip currently supports it [1].
(The wheel is cross-platform, so I guess you could even use Fedora's main
python-pip-wheel package?)

> using simpler tools like python-build and just modifying %py3_install_wheel sounds less maintenance intensive over the long term

Hm, I should find time to switch pyproject-rpm-macros to the simpler tools,
shouldn't I.


[0]
https://packaging.python.org/en/latest/specifications/binary-distribution-format/#is-it-possible-to-import-python-code-directly-from-a-wheel-file
[1]
https://github.com/pypa/pip/blob/a8ba0eec6ac3c1f6cf23f1e2e4c64954bd7a08ed/src/pip/__main__.py#L12


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2134021
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux