[Bug 2055622] Review Request: python-wtforms-sqlalchemy - WTForms integration for SQLAlchemy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2055622



--- Comment #4 from Jakub Kadlčík <jkadlcik@xxxxxxxxxx> ---
> %files -n python3-%{base_name} -f %{pyproject_files}

I think you should add `%license LICENSE.txt` as well.

According to the https://src.fedoraproject.org/rpms/pyproject-rpm-macros/

> %pyproject_save_files can automatically mark license files with
> %license [...]. Only license files declared via PEP 639
> License-File field are detected. 

Which IMHO isn't the case of this package.


> Issues:
> =======
> - Package must not depend on deprecated() packages.
>   Note: python3-sqlalchemy1.3 is deprecated, you must not depend on it.
>   See: https://docs.fedoraproject.org/en-US/packaging-
>   guidelines/deprecating-packages/

For some reason, the package depends on this version of
python3-sqlalchemy? Do you understand why? I am reading the
`setup.cfg` and don't see any such requirement.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2055622
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux