Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tpm-tools - TPM management utilities https://bugzilla.redhat.com/show_bug.cgi?id=394941 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-12-18 11:46 EST ------- For 1.3.1-3: * mixed-use-of-spaces-and-tabs rpmlint ------------------------------------------------------ $ rpmlint -I mixed-use-of-spaces-and-tabs mixed-use-of-spaces-and-tabs : The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. ------------------------------------------------------ * Unneeded BuildRequires - "BuildRequires: autoconf automake libtool" are not needed as this spec file acutally does not use any autotools * Macros in %changelog - When to write macros in %changelog, please use %% to stop macros from being expanded. ------------------------------------------------------- [tasaka1@localhost tpm-tools]$ rpmlint *-3*src*rpm tpm-tools.src:79: W: macro-in-%changelog build tpm-tools.src: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 12) tpm-tools.src:79: W: macro-in-%changelog build tpm-tools.src: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 12) ------------------------------------------------------- ? library linking - tpm-tools contains the library libtpm_unseal.so.0, however no binaries in tpm-tools are using this library?? ------------------------------------------------------- $ rpm -ql tpm-tools | grep '/usr/s*bin' | xargs ldd -r | grep -v '^/usr' | sort | uniq | grep tpm_unseal (no returns) ------------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review