https://bugzilla.redhat.com/show_bug.cgi?id=2134387 --- Comment #1 from Jakub Kadlčík <jkadlcik@xxxxxxxxxx> --- Hello Tibor, thank you for the package. Overall a very good spec file, but there are a few things that need to be fixed. > License: Apache License 2.0 The license is correct but it should be written differently. If you take a look at the allowed licenses documentation page https://docs.fedoraproject.org/en-US/legal/allowed-licenses/ and search for "apache" licenses, you can find "Apache Software License 2.0". In the past, we used to write the Fedora Abbreviation value (e.g. ASL 2.0) into the License field. Now we are moving towards the SPDX expression, so there should be Apache-2.0 in your License field. > Source0: https://github.com/neoave/mrack/releases/download/v%{version}/%{name}-%{version}.tar.gz Not necessary, only a tip. You can use ${URL}/releases/download/v%{version}/%{name}-%{version}.tar.gz it's shorter :-) > %description > mrack is a provisioning tool and a library for CI and local multi-host testing supporting > multiple provisioning providers (e.g. AWS, Beaker, Openstack). But in comparison to other > multi-cloud libraries, the aim is to be able to describe host from application perspective. According to the packaging guidelines, a description shouldn't be any longer than 80 characters per line. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_summary_and_description Can you please re-wrap the lines? > %description cli > %{name}-cli contains mrack command which functionality can be extended by installing mrack plugins Same thing for the subpackages' descriptions > Summary: Multicloud use-case based multihost async provisioner for CIs and testing during development I think the 80 chars rule doesn't apply for a summary but if possible, I would try to stick to it anyway. Summary is usually displayed next to the package name (e.g. in dnf search) and we ideally want to display the information even in smaller terminal windows. > Requires: %{name}-cli == %{version}-%{release} AFAIK there should be only one equal sign. Or at least I haven't seen == before. > %doc README.md I think it would be worth it to provide CHANGELOG.md as well. > mrack-cli.noarch: W: no-manual-page-for-binary mrack This is not a blocker but it would be nice to have a manpage. I am not sure if there is a manpage in the upstream project or a way to generate it but if not, can you please submit an RFE for it and link it in the spec file, so we can easily track it and eventually install it? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2134387 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
