[Bug 2121490] Review Request: rust-sodiumoxide - Fast cryptographic library for Rust

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2121490



--- Comment #6 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
I have debugged the test failure I mentioned above. It appears that the test
code calls a deprecated API in the ed25519 crate ("Signature::new"), which no
longer accepts arbitrary bytes as input, and panics when given invalid data -
which is what this test does.

So you can safely skip that test by using something like

# * skip a test that is not compatible with ed25519 1.3.0+:
#   the Signature::new method now panics when called with invalid bytes
# * skip doctests with missing imports for the new_type! macro
%cargo_test -- -- --skip
crypto::sign::ed25519::test::test_sign_verify_detached_tamper --skip
src/newtype_macros.rs

Please check if you're still seeing the SIGILL crashes when doing that, since I
can't reproduce them on my local system (the package builds successfully for me
with the two skipped tests).


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2121490
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux