[Bug 2134021] Review Request: mingw-pyproject-rpm-macros - RPM macros for PEP 517 MinGW Python packages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2134021



--- Comment #14 from Maxwell G <gotmax@e.email> ---
Virtual environments are a pretty core feature that you should implement, but
they're not actually needed here.

Use the -n / --no-isolation flag to disable venv build isolation. I think the
build isolation mode downloads dependencies from PyPI, so you'd need to disable
that for RPM builds even if venvs did work properly. I should've mentioned that
in the first place :).

> might the current pyproject approach be the better/simpler solution after all?

I guess that's up to you. To me, using simpler tools like python-build and just
modifying %py3_install_wheel sounds less maintenance intensive over the long
term than reimplementing parts of pyprpoject-rpm-macros and keeping up with its
changes, especially if you're not implementing dynamic buildrequires which is
pyproject-rpm-macros' main selling point.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2134021
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux