[Bug 2130607] Review Request: Atomes - An atomistic tool box

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2130607



--- Comment #19 from Alexander Ploumistos <alex.ploumistos@xxxxxxxxx> ---
Hi Sébastien,

(In reply to Sébastien Le Roux from comment #18)
> Hello, 
> 
> so here is my first successful Kojji build: 
> 
> https://koji.fedoraproject.org/koji/taskinfo?taskID=93011742

Well done!



> I had to rename the git repo in: https://github.com/Slookeur/atomes
> (also rename the 'Atomes' repo in 'Atomes-codeblocks' to keep my things
> clear)
> 
> Builds were failing, and likely to fail in the future, when creating a
> release the archive were in the format 
> specified in the spec file, but after extracting they were in a format
> unspecified in the spec file, 
> if that is only possible, ex:
> 
> %global upname Atomes-GNU
> Source0:       
> https://github.com/Slookeur/%{upname}/archive/refs/tags/v%{version}.tar.gz
> 
> Download archive: v1.1.7.tar.gz
> Extracted folder: Atomes-GNU-v1.1.7
> 
> And builders are looking for %{name}-${version}
> And I am not sure where to, if only it is possible, to correct it. 
> And now the spec file looks like: 
> 
> Source0:       
> https://github.com/Slookeur/%{name}/archive/refs/tags/v%{version}.tar.gz

I know it can be a bit tricky sometimes, but you don't need to rename your
repo, you can tweak the %autosetup (or %setup) macro to work with whatever
upstream has provided, e.g.:

* tarball named v1.1.7.tar.gz:
%autosetup -n v%{version}

* tarball named Atomes-GNU-1.1.7.tar.gz:
%autosetup -n %{upname}-%{version}

* tarball named Atomes-GNU-ImBored-1.1.7.tar.gz
%autosetup -n %{upname}-ImBored-%{version}


> Also correct the release number data, and will take car to increment this
> number in the future.

There's a bit of a misunderstanding there. Like I wrote, the package maintainer
increments the release number, but I failed to mention that you are supposed to
do that for a given software version. Once a new version is packaged, you start
again from 1, so your changelog entries would look (random example) like this:

12.7.1-1
12.6.5-3
12.6.5-2
12.6.5-1
…
12.5.9-24
12.5.9-23
…
11.0.8-1
11.0.7.15
11.0.7-14
etc.

Does that help with the numbering scheme?
Here you'll find the full documentation about versioning and it focuses a lot
on the harder/weirder cases, so don't panic when you start scrolling!


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2130607
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux