Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libquikgrid - The QuikGrid generator and contouring routine library Alias: libquikgrid https://bugzilla.redhat.com/show_bug.cgi?id=246524 ------- Additional Comments From kwizart@xxxxxxxxx 2007-12-18 09:43 EST ------- - License is LGPLv2+ (mean you can use any later version) - sorry for the mistake Please use %{SOURCE1} etc to define the source path in %prep - BuildRequiremenet and use for dos2unix could be avoided by using sed: sed -i 's/\r//' readme.txt lesser.txt then please keep timestamps with any reference file like: touch -r reference_file.txt readme.txt lesser.txt - Please keep directory ownership for %{_includedir}/quikgrid, like: %{_includedir}/quikgrid/ or %dir %{_includedir}/quikgrid %{_includedir}/quikgrid/* rpmlint on installed package: undefined-non-weak-symbol /usr/lib64/libquikgrid.so.0.0.0 _Z8DoLineToffi You are probably missing a LDFLAG compiling libquikgrid... This can cause others package to fails while linking to it...(or maybe this is related to mini as i'm using F-7 x86_64 - anyway zlib-devel wasn't BuildRequired, so I'm still searching where it come from) I don't know if there is something wrong with the headers as it do not include others files (so I wonder if there isn't some missing). For the quikgrid.pc , there are something missing, it should point to the appropriate include directory: -I${includedir} with includedir=/usr/include/quikgrid also version seems wrong (it is 5.0) I may try to build something against libquikgrid for proper testing... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review