https://bugzilla.redhat.com/show_bug.cgi?id=2130607 --- Comment #16 from Sébastien Le Roux <sebastien.leroux@xxxxxxxxxxxxxxxx> --- (In reply to Alexander Ploumistos from comment #15) > > The basic idea is to have a single place where one can find the sources that > ... > convenient for you. > Thank you, yes, I understand. > In my opinion, you are unnecessarily complicating your life with all the > different repositories you've set up. Why not keep everything in one place > and add OS-specific logic in your setup scripts? You are absolutely right about this, but there is a reason behind all this, in the main repo, I use a custom Makefile, that I use with codeblocks to code/write Atomes, I wasn't/am not sure that a GNU Makefile could work with codeblocks, it easier and cleaner for me to have both at least for the time being, I will take the time to think about it before deciding on the best way to proceed ;-) ... likely to update the main repo with the content of the GNU tarball ... > These are a few projects whose packages I maintain in Fedora and which > compile and run on different systems: > https://github.com/hvennekate/Molsketch > https://github.com/wojdyr/fityk > https://github.com/SciDAVis/scidavis/tree/master/scidavis > https://framagit.org/razer/bubblemail (not cross-platform, but provides > packages for different distros) > > When you have some time to spare, you can see how they deal with OS-specific > files and packaging. You can also see what information Anitya uses for each > of them. I will ! > > > > *** As part of the review process, you should have provided a link to a > > > successful scratch build in koji. COPR is fine and all, but it's not the > > > "official" build system. Here's one for you: > > > https://koji.fedoraproject.org/koji/taskinfo?taskID=92962219 > > koji build --scratch rawhide Atomes-1.1.6.src.rpm > > Have you managed to discover this document yet? Oh I did, just mentioned it in the mailing list yesterday saying how unclear I think it is ;-) I will work on my Koji build ;-) > > > > I guess this is related to your Koji (local) build, is it ? > > Nope, that's from the use of different source tarballs upstream and in the > source rpm. > Ok thanks for clarifying it ! > Btw, you don't have to edit your first comment whenever you update the spec > file and source rpm, you can just add a new comment with the new URLs, > fedora-review has the logic to pick up the latest version. Also, even though > Atomes has not been included in Fedora yet, there is no problem if the first > version has a non-one release number, e.g. 1.1.6-12. If it helps you keep > track of your files and changes, you can start picking up the habit of > incrementing the release number. Will do ! Again thank you for your expertise, really appreciate your time and efforts, next beer(s) on me ! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2130607 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
