[Bug 2051643] Review Request: lite-xl - A lightweight, simple, fast, feature-filled, and extremely extensible text editor written in C, and Lua, adapted from lite.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2051643



--- Comment #9 from Jakub Kadlčík <jkadlcik@xxxxxxxxxx> ---
Thank you for the changes,


> Issues:
> =======
> - Sources used to build the package match the upstream source, as provided
>   in the spec URL.
>   Note: Upstream MD5sum check error, diff is in
>   /home/jkadlcik/2051643-lite-xl/diff.txt
>   See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/

Unfortunately, the fedora-review tool still complains about the
MD5sum check error.



The following things are minor and I won't block the review because of
them but please consider ...


> So I added a patch file.
> I will contact upstream.

Once you file an upstream issue or a PR, can you please link it in the
spec file? So we can track when the downstream patch is no longer
necessary.


> Summary: A lightweight text editor written in Lua, adapted from lite.

Summary shouldn't end with a period, rpmlint complains about it.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2051643
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux