https://bugzilla.redhat.com/show_bug.cgi?id=2133665 --- Comment #2 from Miroslav Suchý <msuchy@xxxxxxxxxx> --- I would add to %files: %doc CHANGES.md There is no %check. I see two options 1. upstream has test in upstream git, but it is not included in distributed tarball. You can include the whole git-archive as SOURCE1 (while still build the package from SOURCE0) and run test from that git-arhive. In such case, you can even generate documentation for -doc subpackage. Or: 2. even better, do not use pypi sources and use GitHub releases, e.g., https://github.com/EasyPost/syslog-rfc5424-formatter/releases/tag/v1.2.3 which include both documentation and tests. Or: 3. at least try to import the module in %check Beside this, I see no issues. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2133665 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
