https://bugzilla.redhat.com/show_bug.cgi?id=2133551 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@xxxxxxxxx --- Comment #1 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Quick comments from Rust packaging POV: 1) %global __cargo_skip_build 0 Where did you get this? This macro hasn't been used for ages and doesn't do anything. 2) %global __cargo_is_lib() false This should not be necessary. 3) Building against vendored dependencies is forbidden for a Fedora package. At the very least (for ELN / RHEL), they need to be listed as "Provides: bundled(crate(foo)) = 1.2.3" alongside their licenses. 4) > # Needs, at least, tss bindings regen / ExcludeArch: s390x i686 %{power64} This probably needs to be fixed in the rust-tss-esapi-sys package? 5) %{__cargo} build --release --features openssl-kdf/deny_custom This looks very weird, why are you using this custom build command? You should be able to pass features to "%cargo_build" easily enough with something like "%cargo_build -f openssl-kdf/deny_custom". Using standard "%cargo_build" should also make setting "profile.release.debug = true" unnecessary, since the correct flags are set by %cargo_build already. 6) %bcond_without check This does nothing if you don't use %cargo_generate_buildrequires, since there's not even a %check section. 7) License tag does not reflect bundled / statically linked components. General question: The package name is fido-*, the summary mentions FIDO, but the subpackages are fdo* and only mention FDO? Is that the same thing or are there typos in some places? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2133551 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
