https://bugzilla.redhat.com/show_bug.cgi?id=2056369 Jakub Kadlčík <jkadlcik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jkadlcik@xxxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #1 from Jakub Kadlčík <jkadlcik@xxxxxxxxxx> --- Hello Scott, thank you for the package. > License: ASL 2.0 I don't know if it is required yet but we are moving towards SPDX license names, which would be Apache-2.0 according to https://docs.fedoraproject.org/en-US/legal/allowed-licenses/ > URL: https://colcon.readthedocs.io I am thinking about whether we should rather use https://github.com/colcon/colcon-alias I went to the colon.readthedocs.io URL browsed it a little and couldn't find any information about the colcon-alias extension. > %description > An extension for colcon-core to create and modify command aliases. Can you please write 2-3 sentences about the package here? It's not clear to me what it does and how it works. > This spec file is intended to follow the same pattern as the other 38 > `colcon` packages already in Fedora. I wanted to point out a couple of non-standard things in the spec but adhering to the boilerplate of other colcon packages makes a lot of sense and it is IMHO a better idea than nitpicking, so otherwise LGTM. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2056369 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
