https://bugzilla.redhat.com/show_bug.cgi?id=2131603 Otto Liljalaakso <otto.liljalaakso@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? CC| |otto.liljalaakso@xxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |otto.liljalaakso@xxxxxx Status|NEW |ASSIGNED Doc Type|--- |If docs needed, set a value --- Comment #1 from Otto Liljalaakso <otto.liljalaakso@xxxxxx> --- > Name: nagios-plugins-check_newest_file_age According to nagios-plugins naming convention, this should be nagios-plugins-newest_file_age. (This comment is not review blocking.) > BuildRequires: make I believe this is not needed. If it is, ignore this comment. You could do BuildRequires: coreutils to be explicit about having 'install', though. Or just BuildRequires: /usr/bin/install. > [!]: Package must own all directories that it creates. > Note: Directories without known owners: /usr/lib64/nagios, > /usr/lib64/nagios/plugins Please add Requires: nagios-common > [!]: Spec file according to URL is the same as in SRPM. > Note: Spec file as given by url is not the same as in SRPM (see > attached diff). > See: (this test has no URL) This is just because 'fedpkg srpm', fedora-review and rpmautospec are not compatible. No action needed, just do not try to 'fedpkg import' that srpm. > nagios-plugins-check_newest_file_age.x86_64: W: only-non-binary-in-usr-lib $ rpmlint -e only-non-binary-in-usr-lib only-non-binary-in-usr-lib: There are only non binary files in /usr/lib so they should be in /usr/share. Nagios plugins directory in under /usr/lib64, putting a shell script there is valid. No action needed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2131603 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
