https://bugzilla.redhat.com/show_bug.cgi?id=2082886 --- Comment #7 from Otto Liljalaakso <otto.liljalaakso@xxxxxx> --- > Summary: Nagios plugin to check systemd Many existing Nagios plugins seem to use the following convention: "Nagios Plugin - check_systemd". Maybe it would make sense to use it here as well, so that 'dnf search check_systemd' would find it. (This comment is not review blocking.) > [!]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. > Note: Incorrect Requires : /usr/lib64/nagios/plugins > See: https://docs.fedoraproject.org/en-US/packaging- > guidelines/#_file_and_directory_dependencies Your solution for depending on the directory itself makes sense, but unfortunately, the Packaging Guidelines say you SHOULD NOT have a file dependency outside of certain fixed paths. So please just do Requires: nagios-common. Reference is included above. > [!]: Spec file according to URL is the same as in SRPM. > Note: Spec file as given by url is not the same as in SRPM (see > attached diff). > See: (this test has no URL) This is just an incompatibility between 'fedpkg srpm', fedora-review and rpmautospec. No action needed, just remember not to do 'fedpkg import' with that srpm. > Provides > -------- > nagios-plugins-systemd: > python3.11dist(check-systemd) > python3dist(check-systemd) I actually find it quite strange that this plugin is marked as an installed Python package. It does not provide anything that is available for anything else to use, and we already discovered with the problem in %check. Unfortunately, I am not good enough with Python to say, if it would make sense to suggest upstream to install the main content to a module in site-packages. (This comment is not release blocking.) Since there is only one review blocking comment left, and that one is very simple to correct, I do not think it makes sense to strecth the review any longer. Package accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2082886 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
