https://bugzilla.redhat.com/show_bug.cgi?id=2132956 Vít Ondruch <vondruch@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vondruch@xxxxxxxxxx --- Comment #4 from Vít Ondruch <vondruch@xxxxxxxxxx> --- (In reply to Evgeni Golov from comment #3) > (In reply to Ewoud Kohl van Wijngaarden from comment #2) > > This looks good to me. I do wonder about the gemspec file in > > vagrant-scp-doc. Given there's already a gemspec in vagrant-scp I'd say it's > > redundant. > > Technically true, but other vagrant-* packages also have this duplication. If upstream includes the .gemspec in package, we tend to keep it (or address it upstream, but ...). It has different content to `%{vagrant_plugin_spec}` anyway. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2132956 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue