Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: fontmatrix - Font manager https://bugzilla.redhat.com/show_bug.cgi?id=424881 ------- Additional Comments From panemade@xxxxxxxxx 2007-12-17 20:47 EST ------- (In reply to comment #4) > The name seems correct to me. > However there are a few errros > - cosmetic: > - removed work soon from description > - remove redundand BR: gcc-c++ > should be > - removed _word_ "soon" from description > - remove _redundant_ BR > But anyway, I would just rephrase everything to "spec cleanup". Will do above changes. Some reviewer/packagers want to write more explicit some want to write only spec cleanup. I like to write spec cleanup but after seeing many peoples requesting or writing even simple change in changelog I decided to follow them. But anyway I changed that to "spec cleanup" > > - serious: there is a missing BR for cmake Fixed in new version. > > - %build should follow the steps described at > http://fedoraproject.org/wiki/Packaging/cmake and I mean here "%cmake ." instead > of "cmake .". Your version leads to build errors in mock > Fixed in new version. Though I added ctest but there is no tests currently. So should I remove it or I should let it be as per cmake guidelines. > - could you please let me how to verify the sources (or better said, where to > get qmake from) ? I have done a svn checkout, but I was stopped by the following > error: > [wolfy@wolfy fontmatrix]$ cmake ../fontmatrix > -- Building Fontmatrix 0.3.0svn > CMake Error: Qt qmake not found! > -- Configuring done > I have tried to locate qmake using: > [wolfy@wolfy2 ~]$ sudo yum -c /tmp/fedora-devel-x86_64.cfg search \*qmake\* > Setting up repositories > Reading repository metadata in from local files > No Matches found > but failed, as one can see above. Google suggest kdevelop, but it does not seem > to be provided by it, either. > > You need qt4-x11 package. Spec URL: http://paragn.fedorapeople.org/fontmatrix/fontmatrix.spec SRPM URL: http://paragn.fedorapeople.org/fontmatrix/fontmatrix-0.3.0-2.r253.fc8.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review