Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: flam3 - Programs to generate and render cosmic recursive fractal flames https://bugzilla.redhat.com/show_bug.cgi?id=417711 ------- Additional Comments From fedora@xxxxxxxxxxxxxx 2007-12-17 19:29 EST ------- Yes, you are right, it should require the main package. Rereading the review guidelines also tells me that you should make dependencies between your sub-packages fully versioned too, which makes sense: Requires: %{name} = %{version}-%{release} -- After having a look around at some other packages, like readline ( http://cvs.fedoraproject.org/viewcvs/rpms/readline/devel/readline.spec?rev=1.36&view=auto ) I see they also have the static package require the devel package: Requires: %{name}-devel = %{version}-%{release} But I reckon that would create a cyclic dependency here. The reason readline-devel doesn't require readline-static is presumably because it includes a shared library which makes the header files not useless. I still don't think there's much point in installing a header file alone in this case though, but on the other hand, I guess there's no real point in installing just the static lib without the header so I'm a bit hesitant about what to suggest. Personally, I'd whack the header in with the static library (or vice-verse) but that violates a "must" rule. I can't seem to find an existing package that has a static lib without also having a shared lib, so maybe the solution would be to build a shared library too and copy readline's arrangement. However I really don't want to be advising you wrongly. Perhaps input from a more experienced reviewer would be appropriate. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review