[Bug 2132289] Review Request: deepin-network-core - DDE network library and plugins

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2132289



--- Comment #2 from Robin Lee <robinlee.sysu@xxxxxxxxx> ---
Spec URL: https://cheeselee.fedorapeople.org/deepin-network-core.spec
SRPM URL:
https://cheeselee.fedorapeople.org/deepin-network-core-1.0.63-1.fc36.src.rpm

Changes:
- BR gcc-c++
- Comment on the unversioned so file

(In reply to Benson Muite from comment #1)
> Issues from running fedora-review
> 
> - If your application is a C or C++ application you must list a
>   BuildRequires against gcc, gcc-c++ or clang.
>   Note: No gcc, gcc-c++ or clang found in BuildRequires
>   See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/
Done.

> - Development (unversioned) .so files in -devel subpackage, if present.
>   Note: Unversioned so-files directly in %_libdir.
>   See: https://docs.fedoraproject.org/en-US/packaging-
>   guidelines/#_devel_packages
Commented about this. The so file is not versioned.

> 
> Unversioned so-files
> --------------------
> deepin-network-core:
> /usr/lib/dde-control-center/modules/libdcc-network-plugin.so
> deepin-network-core:
> /usr/lib/dde-dock/plugins/system-trays/libdock-network-plugin.so
> deepin-network-core:
> /usr/lib/dde-session-shell/modules/libdss-network-plugin.so
> deepin-network-core-lib: /usr/lib64/libdde-network-core.so


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2132289
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux