https://bugzilla.redhat.com/show_bug.cgi?id=2132022 --- Comment #5 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- 3 minor suggestions: 1) I'd use the new (less confusing) %bcond syntax: %bcond bootstrap 0 2) I'd comment near the bootstrap bcond why it is necessary. 3) I'd extend the test deps comment with something like "They also mix in pre-commit and mypy and we don't need them." -------------------- Running Feodra Review. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2132022 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
