Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xguest - kiosk user setup program https://bugzilla.redhat.com/show_bug.cgi?id=353931 ------- Additional Comments From tmraz@xxxxxxxxxx 2007-12-17 16:50 EST ------- rpmlint -v ../SRPMS/xguest-1.0.5-2.fc8.src.rpm xguest.src: I: checking rpmlint -v ../RPMS/noarch/xguest-1.0.5-2.fc9.noarch.rpm xguest.noarch: I: checking xguest.noarch: E: use-tmp-in-%post xguest.noarch: E: use-of-home-in-%post These two aren't actually a use of it but adding the namespace configuration to namespace.conf. As soon as pam_namespace will support config files in namespace.d this should be changed. Perhaps you should save a backup of the existing namespace.conf so it will be possible to restore it after the future change. Of course the backup should be owned by the package as %ghost. xguest.noarch: E: preun-without-chkconfig /etc/rc.d/init.d/xguest That's a real error and it should be fixed. chkconfig --del should be run for xguest. xguest.noarch: W: service-default-enabled /etc/rc.d/init.d/xguest xguest.noarch: E: no-status-entry /etc/rc.d/init.d/xguest xguest.noarch: W: no-reload-entry /etc/rc.d/init.d/xguest I think these are OK. Status and reload entries do not make much sense as xguest is not a daemon but script containing just some bind mounts. Whether it should be enabled by default or not is debatable but as the %post script creates the xguest user account I think that enabling the polyinstantiation to work for him without further admins actions (except reboot or start of the script for the first time) is fine. xguest.noarch: W: uncompressed-zip /etc/desktop-profiles/xguest.zip That's OK as it is only 177kB anyway. Comment about the wording of Summary and Description: It should be describing what the package does so IMO it should be more like: Summary: Creates xguest user as a locked down user %description Installing this package sets up the xguest user to be used as a temporary account to switch to or as a kiosk user account. The account is disabled unless SELinux is in enforcing mode. The user is only allowed to log in via gdm. The home and temporary directories of the user will be polyinstantiated and mounted on tmpfs. More notes: The URL: http://people.fedoraproject.org/~dwalsh/xguest/%{name}-%{version}.tar.bz2 points to nonexistent file. There is no %defattr(...) on the beginning of %files. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review