[Bug 2056210] Review Request: perl-Lua-API - Interface to Lua's embedding API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2056210



--- Comment #3 from Carl George 🤠 <carl@xxxxxxxxxx> ---
Thanks for the fixes.  The rpmlint errors are different now, and several of
them can be resolved.


perl-Lua-API.x86_64: E: backup-file-in-package
/usr/share/doc/perl-Lua-API/Makefile.PL.orig

This seems like it shouldn't be part of %doc.  In fact lots of those files
don't seem necessary there.

-%doc ChangeLog Changes const-c.inc const-xs.inc Makefile.PL.orig
proto_hints.yml protos protos.yml README wrap_xs.tpl xs_xs.tpl
+%doc ChangeLog Changes README


perl-Lua-API.x86_64: E: non-standard-executable-perm
/usr/lib64/perl5/vendor_perl/auto/Lua/API/API.so 555

Other packages seem to address this with a simple chmod, which should work
here.

+chmod 0755 %{buildroot}%{perl_vendorarch}/auto/Lua/API/API.so


perl-Lua-API-debuginfo.x86_64: W: unstripped-binary-or-object
/usr/lib/debug/usr/lib64/perl5/vendor_perl/auto/Lua/API/API.so-0.04-1.fc38.x86_64.debug
perl-Lua-API-debuginfo.x86_64: E: shared-library-without-dependency-information
/usr/lib/debug/usr/lib64/perl5/vendor_perl/auto/Lua/API/API.so-0.04-1.fc38.x86_64.debug

These go away if the chmod fix is done.


One more thing I noticed, since this review started the license guidelines have
changed.

-License:        GPLv3+
+License:        GPL-3.0-or-later


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2056210
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux