https://bugzilla.redhat.com/show_bug.cgi?id=2131838 --- Comment #1 from Dan Horák <dan@xxxxxxxx> --- formal review is here, see the notes explaining OK* and BAD statuses below: OK source files match upstream: 3b2aa8449ca7050b864e8cd18ed89cb44706fb08 QtXslx-1.4.4.tar.gz OK package meets naming and versioning guidelines. OK* specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK license field matches the actual license. OK license is open source-compatible (MIT). License text included in package. OK latest version is being packaged. OK BuildRequires are proper. OK compiler flags are appropriate. OK package builds in mock (Rawhide/ppc64le). OK debuginfo package looks complete. OK rpmlint is silent. BAD final provides and requires look sane. OK* %check is present and all tests pass. OK shared libraries are added to the regular linker search paths. OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK no scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK headers in devel subpackage OK no pkgconfig files. OK no libtool .la droppings. OK not a GUI app. - Source0 could be simplified to %{url}/archive/v%{version}/%{name}-%{version}.tar.gz - perhaps the Summary could be shortened/modified to eg. "Excel/XLSX file reader/writer library for Qt" - /usr/lib64/cmake/QXlsx should belong to the devel subpackage I believe, QXlsx now provides "cmake(QXlsx)", which sounds wrong - there is a call with ctest, but it says "No tests were found!!!" QXlsx-1.4.4/QXlsx/QXlsx.pri contains very wrong "64-bit" check, I hope our build would override the LIB setting. Or I guess it's not used at all when building with cmake ... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2131838 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
