[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2121585



--- Comment #18 from Renich Bon Ciric <renich@xxxxxxxxxxxxxxxx> ---
Hello Benson,

(In reply to Benson Muite from comment #15)
> Doc package should have 
> BuildArch: noarch

I will add the doc arch immediately. 

> Libraries need versioning, see
> https://docs.fedoraproject.org/en-US/packaging-guidelines/#_shared_libraries

Yeah, well, in this case they're modules/plugins. Very similar to what nginx
uses: https://src.fedoraproject.org/rpms/nginx/blob/f34/f/nginx.spec#_556

That said, upstream has agreed to version those.
https://groups.google.com/g/meetecho-janus/c/ESCW9mQJpYc/m/QuL6uwDlAgAJ

the only issue is that they're gonna add a three digit version: n.n.n. :S

Any suggestions in this regard?

(In reply to Benson Muite from comment #17)
> The html documentation has javascript and webassets:
> https://docs.fedoraproject.org/en-US/packaging-guidelines/JavaScript/
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Web_Assets/

I will read on and fix this as well. 

Thank you! :D


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux