[Bug 2101769] Review Request: pf-bb-config - PF BBDEV (baseband device) Configuration Application

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2101769



--- Comment #2 from Neal Gompa <ngompa13@xxxxxxxxx> ---
> Source0:        https://github.com/intel/pf-bb-config/archive/refs/tags/v%{version}.tar.gz#/pf-bb-config-%{version}.tar.gz

This should be simplified to the following:
"%{url}/archive/v%{version}/pf-bb-config-%{version}.tar.gz"

You're also missing "BuildRequires: make"

> %{_bindir}/*
> %{_datadir}/*

This is not specific enough.

Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2101769
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux