https://bugzilla.redhat.com/show_bug.cgi?id=2091389 --- Comment #8 from Jonathan Wakely <jwakely@xxxxxxxxxx> --- (In reply to Jonathan Wakely from comment #7) > # No tests defined, do a sanity check > # uacme --help gives a return code of 2, so use which > # https://github.com/ndilieto/uacme/issues/50 > %check > which uacme --help > which uacme --version > > This passes the --help and --version options to the 'which' command, is that > what you want? Why? > I think this should just be 'which uacme'. The output of the current %check is: + which uacme --help Usage: which [options] [--] COMMAND [...] Write the full path of COMMAND(s) to standard output. --version, -[vV] Print version and exit successfully. --help, Print this help and exit successfully. --skip-dot Skip directories in PATH that start with a dot. --skip-tilde Skip directories in PATH that start with a tilde. --show-dot Don't expand a dot to current directory in output. --show-tilde Output a tilde for HOME directory for non-root. --tty-only Stop processing options on the right if not on tty. --all, -a Print all matches in PATH, not just the first --read-alias, -i Read list of aliases from stdin. --skip-alias Ignore option --read-alias; don't read stdin. --read-functions Read shell functions from stdin. --skip-functions Ignore option --read-functions; don't read stdin. Recommended use is to write the output of (alias; declare -f) to standard input, so that which can show aliases and shell functions. See which(1) for examples. If the options --read-alias and/or --read-functions are specified then the output can be a full alias or function definition, optionally followed by the full path of each command used inside of those. Report bugs to <which-bugs@xxxxxxx>. GNU which v2.21, Copyright (C) 1999 - 2015 Carlo Wood. GNU which comes with ABSOLUTELY NO WARRANTY; This program is free software; your freedom to use, change and distribute this program is protected by the GPL. + which uacme --version So it's just printing info about /usr/bin/which. It doesn't even check if uacme is in $PATH, and in fact it isn't, because the RPM hasn't been installed. If you want to check the uacme program can actually be run, this would work: # No tests defined, do a sanity check. # uacme --help gives a return code of 2, but pipeline exits with grep's status. # https://github.com/ndilieto/uacme/issues/50 %check ${RPM_BUILD_ROOT}%{_bindir}/%{name} --version 2>&1 | grep 'uacme: version %version' -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2091389 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
