[Bug 2124479] Review Request: llvm-bolt - a post-link optimizer developed to speed up large applications

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2124479



--- Comment #9 from Benson Muite <benson_muite@xxxxxxxxxxxxx> ---
Built Bolt 15.0.0, and those tests did not fail. Maybe the section:

%ifarch x86_64
# Bolt makes incorrect assumptions on the location of libbolt_rt_*.a.
mkdir -p %{_builddir}/%{_libdir}
for rt in libbolt_rt_instr libbolt_rt_hugify libbolt_rt_instr_osx
do
    ln -s %{buildroot}/%{_libdir}/${rt}.a %{_builddir}/%{bolt_srcdir}/bolt/lib/
done
%endif

needs updating?

Build log for failing tests:

FAIL: BOLT :: X86/internal-call-instrument-so.s (82 of 198)
******************** TEST 'BOLT :: X86/internal-call-instrument-so.s' FAILED
********************
Script:
--
: 'RUN: at line 5';   /usr/bin/llvm-mc -filetype=obj -triple
x86_64-unknown-unknown /builddir/build
/BUILD/llvm-project-15.0.0.src/bolt/test/X86/internal-call-instrument-so.s -o
/builddir/build/BUILD
/llvm-project-15.0.0.src/bolt/redhat-linux-build/test/X86/Output/internal-call-instrument-so.s.tmp.
o
: 'RUN: at line 7';   /usr/bin/llvm-strip --strip-unneeded
/builddir/build/BUILD/llvm-project-15.0.
0.src/bolt/redhat-linux-build/test/X86/Output/internal-call-instrument-so.s.tmp.o
: 'RUN: at line 8';   /usr/bin/ld.lld
/builddir/build/BUILD/llvm-project-15.0.0.src/bolt/redhat-lin
ux-build/test/X86/Output/internal-call-instrument-so.s.tmp.o -o
/builddir/build/BUILD/llvm-project-
15.0.0.src/bolt/redhat-linux-build/test/X86/Output/internal-call-instrument-so.s.tmp.exe
-q -shared
 -fini=_fini
: 'RUN: at line 9';   /usr/bin/llvm-bolt --instrument
/builddir/build/BUILD/llvm-project-15.0.0.src
/bolt/redhat-linux-build/test/X86/Output/internal-call-instrument-so.s.tmp.exe
--relocs -o /builddi
r/build/BUILD/llvm-project-15.0.0.src/bolt/redhat-linux-build/test/X86/Output/internal-call-instrum
ent-so.s.tmp.out
--
Exit Code: 1
Command Output (stdout):
--
BOLT-INFO: shared object or position-independent executable detected
BOLT-INFO: Target architecture: x86_64
BOLT-INFO: BOLT version: <unknown>
BOLT-INFO: first alloc address is 0x0
BOLT-INFO: creating new program header table at address 0x200000, offset
0x200000
BOLT-INFO: enabling relocation mode
BOLT-INFO: forcing -jump-tables=move for instrumentation
BOLT-INFO: enabling -align-macro-fusion=all since no profile was specified
BOLT-INFO: enabling lite mode
BOLT-INSTRUMENTER: Number of indirect call site descriptors: 0
BOLT-INSTRUMENTER: Number of indirect call target descriptors: 2
BOLT-INSTRUMENTER: Number of function descriptors: 2
BOLT-INSTRUMENTER: Number of branch counters: 2
BOLT-INSTRUMENTER: Number of ST leaf node counters: 4
BOLT-INSTRUMENTER: Number of direct call counters: 0
BOLT-INSTRUMENTER: Total number of counters: 6
BOLT-INSTRUMENTER: Total size of counters: 48 bytes (static alloc memory)
BOLT-INSTRUMENTER: Total size of string table emitted: 13 bytes in file
BOLT-INSTRUMENTER: Total size of descriptors: 296 bytes in file
BOLT-INSTRUMENTER: Profile will be saved to file /tmp/prof.fdata
BOLT-INFO: 0 out of 2 functions in the binary (0.0%) have non-empty execution
profile
BOLT-INFO: 0 instructions were shortened
BOLT-INFO: UCE removed 0 blocks and 0 bytes of code.
BOLT-INFO: SCTC: patched 0 tail calls (0 forward) tail calls (0 backward) from
a total of 0 while r
emoving 0 double jumps and removing 0 basic blocks totalling 0 bytes of code.
CTCs total execution 
count is 0 and the number of times CTCs are taken is 0.
--
Command Output (stderr):
--
BOLT-WARNING: will skip the following function(s) as unsupported internal calls
were detected:
              _start
BOLT-ERROR: library not found: /usr/lib/libbolt_rt_instr.a
--
********************
FAIL: BOLT :: X86/internal-call-instrument.s (83 of 198)
******************** TEST 'BOLT :: X86/internal-call-instrument.s' FAILED
********************
Script:
--
: 'RUN: at line 5';   /usr/bin/llvm-mc -filetype=obj -triple
x86_64-unknown-unknown /builddir/build
/BUILD/llvm-project-15.0.0.src/bolt/test/X86/internal-call-instrument.s -o
/builddir/build/BUILD/ll
vm-project-15.0.0.src/bolt/redhat-linux-build/test/X86/Output/internal-call-instrument.s.tmp.o
: 'RUN: at line 7';   /usr/bin/llvm-strip --strip-unneeded
/builddir/build/BUILD/llvm-project-15.0.
0.src/bolt/redhat-linux-build/test/X86/Output/internal-call-instrument.s.tmp.o
: 'RUN: at line 8';   /usr/bin/clang
/builddir/build/BUILD/llvm-project-15.0.0.src/bolt/redhat-linu
x-build/test/X86/Output/internal-call-instrument.s.tmp.o -o
/builddir/build/BUILD/llvm-project-15.0
.0.src/bolt/redhat-linux-build/test/X86/Output/internal-call-instrument.s.tmp.exe
-Wl,-q
: 'RUN: at line 10';   /usr/bin/llvm-bolt --instrument
/builddir/build/BUILD/llvm-project-15.0.0.sr
c/bolt/redhat-linux-build/test/X86/Output/internal-call-instrument.s.tmp.exe
--relocs -o /builddir/
build/BUILD/llvm-project-15.0.0.src/bolt/redhat-linux-build/test/X86/Output/internal-call-instrumen
t.s.tmp.out
--
Exit Code: 1
Command Output (stdout):
--
BOLT-INFO: shared object or position-independent executable detected
BOLT-INFO: Target architecture: x86_64
BOLT-INFO: BOLT version: <unknown>
BOLT-INFO: first alloc address is 0x0
BOLT-INFO: creating new program header table at address 0x200000, offset
0x200000
BOLT-INFO: enabling relocation mode
BOLT-INFO: forcing -jump-tables=move for instrumentation
BOLT-INFO: enabling -align-macro-fusion=all since no profile was specified
BOLT-INFO: enabling lite mode
BOLT-INSTRUMENTER: Number of indirect call site descriptors: 2
BOLT-INSTRUMENTER: Number of indirect call target descriptors: 7
BOLT-INSTRUMENTER: Number of function descriptors: 7
BOLT-INSTRUMENTER: Number of branch counters: 5
BOLT-INSTRUMENTER: Number of ST leaf node counters: 13
BOLT-INSTRUMENTER: Number of direct call counters: 0
BOLT-INSTRUMENTER: Total number of counters: 18
BOLT-INSTRUMENTER: Total size of counters: 144 bytes (static alloc memory)
BOLT-INSTRUMENTER: Total size of string table emitted: 147 bytes in file
BOLT-INSTRUMENTER: Total size of descriptors: 972 bytes in file
BOLT-INSTRUMENTER: Profile will be saved to file /tmp/prof.fdata
BOLT-INFO: 0 out of 10 functions in the binary (0.0%) have non-empty execution
profile
BOLT-INFO: 0 instructions were shortened
BOLT-INFO: UCE removed 3 blocks and 120 bytes of code.
BOLT-INFO: SCTC: patched 0 tail calls (0 forward) tail calls (0 backward) from
a total of 0 while r
emoving 0 double jumps and removing 0 basic blocks totalling 0 bytes of code.
CTCs total execution 
count is 0 and the number of times CTCs are taken is 0.
--
Command Output (stderr):
--
/usr/bin/ld: warning:
/builddir/build/BUILD/llvm-project-15.0.0.src/bolt/redhat-linux-build/test/X8
6/Output/internal-call-instrument.s.tmp.o: missing .note.GNU-stack section
implies executable stack
/usr/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future
version of the link
er
BOLT-WARNING: will skip the following function(s) as unsupported internal calls
were detected:
              main
BOLT-ERROR: library not found: /usr/lib/libbolt_rt_instr.a
--
********************


******************** TEST 'BOLT :: X86/asm-dump.c' FAILED ********************
Script:
--
: 'RUN: at line 7';   /usr/bin/clang -fPIC
/builddir/build/BUILD/llvm-project-15.0.0.src/bolt/test/
X86/asm-dump.c -o
/builddir/build/BUILD/llvm-project-15.0.0.src/bolt/redhat-linux-build/test/X86/Ou
tput/asm-dump.c.tmp.exe -Wl,-q
: 'RUN: at line 10';   /usr/bin/llvm-bolt
/builddir/build/BUILD/llvm-project-15.0.0.src/bolt/redhat
-linux-build/test/X86/Output/asm-dump.c.tmp.exe --instrument
--instrumentation-file=/builddir/build
/BUILD/llvm-project-15.0.0.src/bolt/redhat-linux-build/test/X86/Output/asm-dump.c.tmp.fdata
-o /bui
lddir/build/BUILD/llvm-project-15.0.0.src/bolt/redhat-linux-build/test/X86/Output/asm-dump.c.tmp.in
str
: 'RUN: at line 13';  
/builddir/build/BUILD/llvm-project-15.0.0.src/bolt/redhat-linux-build/test/X
86/Output/asm-dump.c.tmp.instr >
/builddir/build/BUILD/llvm-project-15.0.0.src/bolt/redhat-linux-bu
ild/test/X86/Output/asm-dump.c.tmp.result
: 'RUN: at line 16';   /usr/bin/llvm-bolt
/builddir/build/BUILD/llvm-project-15.0.0.src/bolt/redhat
-linux-build/test/X86/Output/asm-dump.c.tmp.exe -p
/builddir/build/BUILD/llvm-project-15.0.0.src/bo
lt/redhat-linux-build/test/X86/Output/asm-dump.c.tmp.fdata --funcs=main
--asm-dump=/builddir/build/
BUILD/llvm-project-15.0.0.src/bolt/redhat-linux-build/test/X86/Output/asm-dump.c.tmp
-o /dev/null  
  | /usr/bin/FileCheck
/builddir/build/BUILD/llvm-project-15.0.0.src/bolt/test/X86/asm-dump.c --che
ck-prefix=CHECK-BOLT
: 'RUN: at line 20';   cat
/builddir/build/BUILD/llvm-project-15.0.0.src/bolt/redhat-linux-build/te
st/X86/Output/asm-dump.c.tmp/main.s | /usr/bin/FileCheck
/builddir/build/BUILD/llvm-project-15.0.0.
src/bolt/test/X86/asm-dump.c --check-prefix=CHECK-FILE
: 'RUN: at line 24';   sed -i 's/\.L/L/g'
/builddir/build/BUILD/llvm-project-15.0.0.src/bolt/redhat
-linux-build/test/X86/Output/asm-dump.c.tmp/main.s
: 'RUN: at line 27';   /usr/bin/llvm-mc -filetype=obj -triple
x86_64-unknown-unknown /builddir/buil
d/BUILD/llvm-project-15.0.0.src/bolt/redhat-linux-build/test/X86/Output/asm-dump.c.tmp/main.s
-o /b
uilddir/build/BUILD/llvm-project-15.0.0.src/bolt/redhat-linux-build/test/X86/Output/asm-dump.c.tmp.
o
: 'RUN: at line 30';   /usr/bin/python3
/builddir/build/BUILD/llvm-project-15.0.0.src/bolt/test/lin
k_fdata.py
/builddir/build/BUILD/llvm-project-15.0.0.src/bolt/redhat-linux-build/test/X86/Output/as
m-dump.c.tmp/main.s
/builddir/build/BUILD/llvm-project-15.0.0.src/bolt/redhat-linux-build/test/X86/
Output/asm-dump.c.tmp.o
/builddir/build/BUILD/llvm-project-15.0.0.src/bolt/redhat-linux-build/test/
X86/Output/asm-dump.c.tmp.fdata.reconst
: 'RUN: at line 38';   /usr/bin/llvm-strip --strip-unneeded
/builddir/build/BUILD/llvm-project-15.0
.0.src/bolt/redhat-linux-build/test/X86/Output/asm-dump.c.tmp.o
: 'RUN: at line 41';   /usr/bin/clang -fPIC
/builddir/build/BUILD/llvm-project-15.0.0.src/bolt/redh
at-linux-build/test/X86/Output/asm-dump.c.tmp.o -o
/builddir/build/BUILD/llvm-project-15.0.0.src/bo
lt/redhat-linux-build/test/X86/Output/asm-dump.c.tmp.exe.reopt -Wl,-q
: 'RUN: at line 44';   /usr/bin/llvm-bolt
/builddir/build/BUILD/llvm-project-15.0.0.src/bolt/redhat
-linux-build/test/X86/Output/asm-dump.c.tmp.exe.reopt -p
/builddir/build/BUILD/llvm-project-15.0.0.
src/bolt/redhat-linux-build/test/X86/Output/asm-dump.c.tmp.fdata.reconst -o
/dev/null    | /usr/bin
/FileCheck
/builddir/build/BUILD/llvm-project-15.0.0.src/bolt/test/X86/asm-dump.c
--check-prefix=CH
ECK-REOPT
--
Exit Code: 1
Command Output (stdout):
--
BOLT-INFO: shared object or position-independent executable detected
BOLT-INFO: Target architecture: x86_64
BOLT-INFO: BOLT version: <unknown>
BOLT-INFO: first alloc address is 0x0
BOLT-INFO: creating new program header table at address 0x200000, offset
0x200000
BOLT-INFO: enabling relocation mode
BOLT-INFO: forcing -jump-tables=move for instrumentation
BOLT-INFO: enabling -align-macro-fusion=all since no profile was specified
BOLT-INFO: enabling lite mode
BOLT-INSTRUMENTER: Number of indirect call site descriptors: 2
BOLT-INSTRUMENTER: Number of indirect call target descriptors: 7
BOLT-INSTRUMENTER: Number of function descriptors: 7
BOLT-INSTRUMENTER: Number of branch counters: 7
BOLT-INSTRUMENTER: Number of ST leaf node counters: 14
BOLT-INSTRUMENTER: Number of direct call counters: 0
BOLT-INSTRUMENTER: Total number of counters: 21
BOLT-INSTRUMENTER: Total size of counters: 168 bytes (static alloc memory)
BOLT-INSTRUMENTER: Total size of string table emitted: 168 bytes in file
BOLT-INSTRUMENTER: Total size of descriptors: 1272 bytes in file
BOLT-INSTRUMENTER: Profile will be saved to file
/builddir/build/BUILD/llvm-project-15.0.0.src/bolt
/redhat-linux-build/test/X86/Output/asm-dump.c.tmp.fdata
BOLT-INFO: 0 out of 10 functions in the binary (0.0%) have non-empty execution
profile
BOLT-INFO: 8 instructions were shortened
BOLT-INFO: UCE removed 3 blocks and 120 bytes of code.
BOLT-INFO: SCTC: patched 0 tail calls (0 forward) tail calls (0 backward) from
a total of 0 while r
emoving 0 double jumps and removing 0 basic blocks totalling 0 bytes of code.
CTCs total execution 
count is 0 and the number of times CTCs are taken is 0.
--
Command Output (stderr):
--
BOLT-ERROR: library not found: /usr/lib/libbolt_rt_instr.a
--
********************



Is it possible to update to 15.0.1 or 15.0.2 assuming this will be released
soon?


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2124479
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux