https://bugzilla.redhat.com/show_bug.cgi?id=2080809 Jakub Kadlčík <jkadlcik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value CC| |jkadlcik@xxxxxxxxxx --- Comment #1 from Jakub Kadlčík <jkadlcik@xxxxxxxxxx> --- Hello Adam, thank you for the package. Overall, the package looks very well. > Name: python-pyvips > Version: 2.2.0 > Release: 1%{?dist} This is up to your preference but I would suggest not aligning text into columns like these using TABs. It breaks when another person is using a different TAB width than you. For example, you can try vim python-pyvips.spec :set tabstop=12 or just experimenting with various TAB widths in your favorite editor. When using spaces, the columns are always aligned the same. (This is a different topic from TABs vs spaces for indentation, i.e. whitespace on the beginning of the line. I wouldn't have any suggestions there because I don't want to start a holy war :D) > Version: 2.2.0 There is already version 2.2.1, can you please update? > %global _description %{expand: > %{summary}. > > Programs that use pyvips don't manipulate images directly, instead IMHO there is no reason to have the %{summary} here > %check > %tox I am a bit confused about this but to me, it seems that the tests aren't actually being executed. This happens during a build /usr/bin/python3 -m tox --current-env -q --recreate -e py311 py311: commands succeeded congratulations :) and it happens instantly, in 0 seconds. In comparison, running `tox` inside the git repository, takes much longer and one can see unit tests being executed. > %files -n python3-pyvips -f %{pyproject_files} > %doc README.rst I think we should add %license LICENSE.txt as well -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2080809 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
