[Bug 2130496] Review Request: python-pidfile - Python context manager for managing pid files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2130496



--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
1) This SPEC is creating binary python-pidfile. It should created
python3-pidfile.
Change
%files -n %{name} -f %{pyproject_files}
to
%files -n python3-pidfile -f %{pyproject_files}

2) You don't need to write explicitly
Requires:               python3-psutil
Drop this it will be autogenerated.

3) Its not clear which MIT license variant this package will be using. Maybe
ask upstream to add the license text in upstream code or ask them to is this
project following
https://fedoraproject.org/wiki/Licensing:MIT?rd=Licensing/MIT#Modern_Style_with_sublicense
or https://fedoraproject.org/wiki/Licensing/MIT-0 license.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2130496
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux