https://bugzilla.redhat.com/show_bug.cgi?id=2087143 Jakub Kadlčík <jkadlcik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value CC| |jkadlcik@xxxxxxxxxx --- Comment #2 from Jakub Kadlčík <jkadlcik@xxxxxxxxxx> --- Hello fedepell, thank you for the package. Overall it looks very good. > Spec URL stays the same: ... > SRPM URL for FC35: ... The links need to point directly to the raw file or file download. In the case of the spec, you want to go to the link you posted, click the "Raw" button, and use that URL. For the SRPM, you want to "Copy link address" for the "Download" button and use that. There are tools that we use for the review, that download those files, so they need direct links. > Patch0: 0001-Patch_tests_with_Python_3_11.patch Is there any upstream pull request with this patch? If yes, can you please add a link here as a comment above the patch? Otherwise, can you please submit the PR? Then we will easily know when we can drop the patch from the package. > %global _description %{expand: According to the packaging guidelines https://docs.fedoraproject.org/en-US/packaging-guidelines/#_summary_and_description the description lines should be no longer than 80 characters. Can you please re-wrap them? > %{_bindir}/* Can you please be more specific, instead of using wildcard here? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2087143 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
