https://bugzilla.redhat.com/show_bug.cgi?id=2115102 --- Comment #19 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- 10) [MUST] "at least a basic smoke test (such as importing the packaged module) MUST be run in %check" https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_tests However I see that upstream has proper tests, so you SHOULD try to run those if at all possible. "If a test suite exists upstream, it SHOULD be run in the %check section" (same guideline as the one quoted above). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2115102 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
