https://bugzilla.redhat.com/show_bug.cgi?id=2128851 --- Comment #2 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Packages have proper BuildRequires/Requires on javapackages-tools (jpackage-utils) - Javadoc documentation files are generated and included in -javadoc subpackage Note: No javadoc subpackage present. Note: Javadocs are optional for Fedora versions >= 21 See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation - Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Note: No javadoc subpackage present See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation ===== MUST items ===== C/C++: [?]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 3-Clause License", "*No copyright* [generated file]", "*No copyright* BSD 3-Clause License". 113 files have unknown license. Detailed output of licensecheck in /home/FedoraPackaging/reviews/snowball/2128851-snowball/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/java [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [?]: Package does not generate any conflict. [-]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [?]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 112640 bytes in 6 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build Maven: [-]: If package contains pom.xml files install it (including metadata) even when building with ant [x]: Old add_to_maven_depmap macro is not being used Python: [-]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libstemmer , libstemmer-devel , snowball-java , python3-snowballstemmer [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [?]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Java: [x]: Packages are noarch unless they use JNI Note: snowball subpackage is not noarch. Please verify manually [x]: Package uses upstream build method (ant/maven/etc.) ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (debuginfo) ------------------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 7 snowball-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/.dwz/snowball-2.2.0-3.fc38.x86_64 snowball-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/bin/snowball-2.2.0-3.fc38.x86_64.debug snowball-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/bin/stemwords-2.2.0-3.fc38.x86_64.debug snowball-debuginfo.x86_64: E: statically-linked-binary /usr/lib/debug/.dwz/snowball-2.2.0-3.fc38.x86_64 snowball.x86_64: W: no-manual-page-for-binary snowball snowball.x86_64: W: no-manual-page-for-binary stemwords snowball-debugsource.x86_64: W: no-documentation snowball-debuginfo.x86_64: W: no-documentation snowball.x86_64: W: name-repeated-in-summary Snowball snowball-debuginfo.x86_64: E: missing-PT_GNU_STACK-section /usr/lib/debug/.dwz/snowball-2.2.0-3.fc38.x86_64 snowball-debuginfo.x86_64: E: ldd-failed /usr/lib/debug/usr/bin/snowball-2.2.0-3.fc38.x86_64.debug /usr/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) ldd: warning: you do not have execution permission for `/usr/lib/debug/usr/bin/snowball-2.2.0-3.fc38.x86_64.debug' snowball-debuginfo.x86_64: E: ldd-failed /usr/lib/debug/usr/bin/stemwords-2.2.0-3.fc38.x86_64.debug /usr/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) ldd: warning: you do not have execution permission for `/usr/lib/debug/usr/bin/stemwords-2.2.0-3.fc38.x86_64.debug' libstemmer-devel.x86_64: W: invalid-license BSD-3-Clause snowball-debugsource.x86_64: W: invalid-license BSD-3-Clause snowball-debuginfo.x86_64: W: invalid-license BSD-3-Clause libstemmer.x86_64: W: invalid-license BSD-3-Clause snowball.x86_64: W: invalid-license BSD-3-Clause python3-snowballstemmer.noarch: W: invalid-license BSD-3-Clause snowball-java.noarch: W: invalid-license BSD-3-Clause snowball-debuginfo.x86_64: W: hidden-file-or-dir /usr/lib/debug/.dwz snowball-debuginfo.x86_64: W: hidden-file-or-dir /usr/lib/debug/.dwz snowball-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/31/f35251e309daa3b72e03474036ee4f2d2dea61 ../../../.build-id/31/f35251e309daa3b72e03474036ee4f2d2dea61 snowball-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/a2/d3d51b2fc41bfe648c4b6637daa451c78b24f8 ../../../.build-id/a2/d3d51b2fc41bfe648c4b6637daa451c78b24f8 7 packages and 0 specfiles checked; 4 errors, 19 warnings, 4 badness; has taken 2.7 s Source checksums ---------------- https://github.com/snowballstem/snowball-data/archive/refs/heads/master.zip : CHECKSUM(SHA256) this package : bf5447c806e433b1caf39f42031f37e0b6d09115442dd5c81d391d5761934fc7 CHECKSUM(SHA256) upstream package : bf5447c806e433b1caf39f42031f37e0b6d09115442dd5c81d391d5761934fc7 https://github.com/snowballstem/snowball/archive/v2.2.0/snowball-2.2.0.tar.gz : CHECKSUM(SHA256) this package : 425cdb5fba13a01db59a1713780f0662e984204f402d3dae1525bda9e6d30f1a CHECKSUM(SHA256) upstream package : 425cdb5fba13a01db59a1713780f0662e984204f402d3dae1525bda9e6d30f1a Requires -------- snowball (rpmlib, GLIBC filtered): libc.so.6()(64bit) libstemmer.so.0()(64bit) rtld(GNU_HASH) libstemmer (rpmlib, GLIBC filtered): libc.so.6()(64bit) rtld(GNU_HASH) libstemmer-devel (rpmlib, GLIBC filtered): libstemmer(x86-64) libstemmer.so.0()(64bit) snowball-java (rpmlib, GLIBC filtered): python3-snowballstemmer (rpmlib, GLIBC filtered): python(abi) snowball-debuginfo (rpmlib, GLIBC filtered): snowball-debugsource (rpmlib, GLIBC filtered): Provides -------- snowball: snowball snowball(x86-64) libstemmer: libstemmer libstemmer(x86-64) libstemmer.so.0()(64bit) libstemmer-devel: libstemmer-devel libstemmer-devel(x86-64) snowball-java: snowball-java python3-snowballstemmer: python-snowballstemmer python3-snowballstemmer python3.11-snowballstemmer python3.11dist(snowballstemmer) python3dist(snowballstemmer) snowball-debuginfo: debuginfo(build-id) snowball-debuginfo snowball-debuginfo(x86-64) snowball-debugsource: snowball-debugsource snowball-debugsource(x86-64) Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2128851 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Java, C/C++, Python Disabled plugins: Perl, Ocaml, SugarActivity, R, Haskell, fonts, PHP Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH Comments: a) add "make check_java" and "make check_python" to the spec file. b) should there be an obsoletes section in the spec for python-snowball-stemmer and libstemmer? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2128851 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
