https://bugzilla.redhat.com/show_bug.cgi?id=2129390 Robert Scheck <redhat-bugzilla@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |redhat-bugzilla@linuxnetz.d | |e Doc Type|--- |If docs needed, set a value --- Comment #2 from Robert Scheck <redhat-bugzilla@xxxxxxxxxxxx> --- Thank you for your contribution! This is not a formal review, but some findings when having a very first look to it: - Summary tag is too long and quoted See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_summary_and_description - Description tag is quoted and shorter than summary See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_summary_and_description - Source0 should use URL to upstream tarball See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ - Don't disable %debug_package See: https://docs.fedoraproject.org/en-US/packaging-guidelines/Debuginfo/ - License tag doesn't use SPDX See: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/ - Use %{_bindir} instead of /usr/bin See: https://docs.fedoraproject.org/en-US/packaging-guidelines/RPMMacros/ - COPYING listed in %doc and %license -> remove from %doc See: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/ - Requires tag seems to be unnecessary due to SONAME See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_requires Hint: A possible future formal reviewer will follow these guidelines: https://docs.fedoraproject.org/en-US/packaging-guidelines/ReviewGuidelines/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2129390 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
