https://bugzilla.redhat.com/show_bug.cgi?id=2051062 --- Comment #5 from Jakub Kadlčík <jkadlcik@xxxxxxxxxx> --- Thank you for the changes, > The upstream developer strongly believe that the user should write their > own configuration based on the example they provide and don't have any > support for the default config (in fact support for the default system > config was removed at some point just before the initial release). > Which means there's no default keybindings :( > > README.md describes how to start in the Usage section, but I agree that it > raises the entry barrier a bit higher than usual even for tiling WMs. Yep, that's a bit strange decision to me but my opinion isn't important here, nor it is important for the package review. But thank you for the explanation :-) > Ah, here comes the complicated part: > zig, being still actively developed and designed, does not have any > support for sharing the code yet. Think rust with its unstable ABI, > but without a package manager or a standard library location. > > So all the bundled code is embedded to the repo as git submodules > and the paths are hardcoded in the buildsystem. Plus some details > of the build system which make it even more inconvenient. > > Tl;dr: I don't want to deal with that until the Zig toolchain evolves > to offer some package/code reuse solution. And until we have support > for that in zig-rpm-macros. Aha, makes sense, thank you. The bundling is AFAIK done correctly and I asked on #fedora-devel if it is okay to bundle in this case and got their blessing. I like that you put an explanation into the spec file. > I did not see any value for the end user in this file; any prospective > contributor to the project will find the same info in the git repository. Ok, no problem > error: file contains key "DesktopNames" in group "Desktop Entry", > but keys extending the format should start with "X-" Ah, :-/ Well, at least we tried. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2051062 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
