https://bugzilla.redhat.com/show_bug.cgi?id=2051062 --- Comment #2 from Jakub Kadlčík <jkadlcik@xxxxxxxxxx> --- > Issues: > ======= > - Package installs a %{name}.desktop using desktop-file-install or desktop- > file-validate if there is such a file. The fedora-review tool complains about this. I think we need to do something like %check desktop-file-validate %{buildroot}%{_datadir}/wayland-sessions/%{name}.desktop > NTP License (legal disclaimer) Historical Permission Notice and Disclaimer - sell variant > ----------------------------------------------------------------------------------------- > /home/jkadlcik/2051062-river/upstream-unpacked/Source0/river-0.1.3/deps/zig-wlroots/protocol/wlr-layer-shell-unstable-v1.xml > /home/jkadlcik/2051062-river/upstream-unpacked/Source0/river-0.1.3/protocol/wlr-layer-shell-unstable-v1.xml This license isn't mentioned in the License field but I am not sure if it is necessary. > [ ]: Package must own all directories that it creates. > Note: Directories without known owners: /usr/share/river There is %{_datadir}/%{name}/init.example in the %files section. We need to change it or add a new line for the whole directory. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2051062 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue