[Bug 2051062] Review Request: river - Dynamic tiling Wayland compositor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2051062

Jakub Kadlčík <jkadlcik@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value
                 CC|                            |jkadlcik@xxxxxxxxxx



--- Comment #1 from Jakub Kadlčík <jkadlcik@xxxxxxxxxx> ---
Hello Aleksei,
thank you for the package.

I tried to install and run it, and I think it works - I got a blue
screen and a mouse cursor. Maybe if you are a river developer, you might 
want to describe the default key bindings in some README because I don't 
know how to launch any applications :D. But that's outside of the 
package-review scope.


Just for the record, the package fails to build for F35 but it will
be EOL soon, so I think we don't care about it anymore.


> Source100:      %{name}.desktop

Why not Source3?


> # bundled sources
> Provides:       bundled(zig-pixman)
> Provides:       bundled(zig-wayland)
> Provides:       bundled(zig-wlroots)
> Provides:       bundled(zig-xkbcommon)

My apologies, I have zero experience with Zig programming language and
with compiled programming languages overall, for that matter.

Is it absolutely necessary to bundle these? Packaging guidelines
https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling
tells us to make every effort to avoid bundling.


> %description

I just wanted to say that I like the well-written description


> %zig_build \
>   -Dxwayland
>
>
> %zig_install \
>    -Dxwayland

A bit unnecessary to wrap the linen there but I don't mind


> %license LICENSE
> %doc README.md

Maybe we can add %doc CONTRIBUTING.md as well?


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2051062
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux