https://bugzilla.redhat.com/show_bug.cgi?id=2120661 Miroslav Suchý <msuchy@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #5 from Miroslav Suchý <msuchy@xxxxxxxxxx> --- [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib64/libdnf5/plugins, /usr/lib64/libdnf5 [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/dbus-1/system- services, /usr/share/polkit-1/actions, /usr/lib64/libdnf5/plugins, /usr/share/dbus-1/interfaces, /usr/share/polkit-1, /etc/dbus-1, /usr/lib64/libdnf5, /usr/share/dbus-1, /etc/dbus-1/system.d You either should own these directories or require some package that owns them. - Package must not depend on deprecated() packages. Note: openssl1.1-devel is deprecated, you must not depend on it. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/deprecating-packages/ - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/lib/python3.11/site- packages/libdnf_plugins/README See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files This is caused by %{python3_sitelib}/libdnf_plugins/ %doc %{python3_sitelib}/libdnf_plugins/README because REDAME is the only file in this directory, just put %dir there. I.e.: %dir %{python3_sitelib}/libdnf_plugins/ %doc %{python3_sitelib}/libdnf_plugins/README Several Summary fields ends with dot. Summary should not end with dot. Summary should start with capital character. E.g., dnf5-plugin start with lowercase. /etc/dnf/dnf5-aliases.d/README should be marked as %doc I am worried about rpmlint error dnf5-debuginfo.x86_64: E: missing-PT_GNU_STACK-section /usr/lib/debug/.dwz/dnf5-5.0.0-0~pre.fc38.x86_64 but I have no idea what it means. This as well dnf5daemon-server.x86_64: E: dbus-policy-allow-without-destination <allow send_interface="org.rpm.dnf.v0"/> /etc/dbus-1/system.d/org.rpm.dnf.v0.conf dnf5daemon-server.x86_64: E: dbus-policy-allow-without-destination <allow send_interface="org.rpm.dnf.v0"/> /etc/dbus-1/system.d/org.rpm.dnf.v0.conf Unversioned so-files -------------------- perl5-libdnf5: /usr/lib64/perl5/vendor_perl/auto/libdnf5/base/base.so perl5-libdnf5: /usr/lib64/perl5/vendor_perl/auto/libdnf5/common/common.so perl5-libdnf5: /usr/lib64/perl5/vendor_perl/auto/libdnf5/comps/comps.so perl5-libdnf5: /usr/lib64/perl5/vendor_perl/auto/libdnf5/conf/conf.so perl5-libdnf5: /usr/lib64/perl5/vendor_perl/auto/libdnf5/logger/logger.so perl5-libdnf5: /usr/lib64/perl5/vendor_perl/auto/libdnf5/plugin/plugin.so perl5-libdnf5: /usr/lib64/perl5/vendor_perl/auto/libdnf5/repo/repo.so perl5-libdnf5: /usr/lib64/perl5/vendor_perl/auto/libdnf5/rpm/rpm.so perl5-libdnf5: /usr/lib64/perl5/vendor_perl/auto/libdnf5/transaction/transaction.so perl5-libdnf5-cli: /usr/lib64/perl5/vendor_perl/auto/libdnf5_cli/progressbar/progressbar.so python3-libdnf5: /usr/lib64/python3.11/site-packages/libdnf5/_base.so python3-libdnf5: /usr/lib64/python3.11/site-packages/libdnf5/_common.so python3-libdnf5: /usr/lib64/python3.11/site-packages/libdnf5/_comps.so python3-libdnf5: /usr/lib64/python3.11/site-packages/libdnf5/_conf.so python3-libdnf5: /usr/lib64/python3.11/site-packages/libdnf5/_logger.so python3-libdnf5: /usr/lib64/python3.11/site-packages/libdnf5/_plugin.so python3-libdnf5: /usr/lib64/python3.11/site-packages/libdnf5/_repo.so python3-libdnf5: /usr/lib64/python3.11/site-packages/libdnf5/_rpm.so python3-libdnf5: /usr/lib64/python3.11/site-packages/libdnf5/_transaction.so python3-libdnf5-cli: /usr/lib64/python3.11/site-packages/libdnf5_cli/_progressbar.so ruby-libdnf5: /usr/lib64/ruby/vendor_ruby/libdnf5/base.so ruby-libdnf5: /usr/lib64/ruby/vendor_ruby/libdnf5/common.so ruby-libdnf5: /usr/lib64/ruby/vendor_ruby/libdnf5/comps.so ruby-libdnf5: /usr/lib64/ruby/vendor_ruby/libdnf5/conf.so ruby-libdnf5: /usr/lib64/ruby/vendor_ruby/libdnf5/logger.so ruby-libdnf5: /usr/lib64/ruby/vendor_ruby/libdnf5/plugin.so ruby-libdnf5: /usr/lib64/ruby/vendor_ruby/libdnf5/repo.so ruby-libdnf5: /usr/lib64/ruby/vendor_ruby/libdnf5/rpm.so ruby-libdnf5: /usr/lib64/ruby/vendor_ruby/libdnf5/transaction.so ruby-libdnf5-cli: /usr/lib64/ruby/vendor_ruby/libdnf5_cli/progressbar.so libdnf5-plugin-actions: /usr/lib64/libdnf5/plugins/actions.so python3-libdnf5-python-plugins-loader: /usr/lib64/libdnf5/plugins/python_plugins_loader.so dnf5-plugins: /usr/lib64/dnf5/plugins/builddep_cmd_plugin.so dnf5-plugins: /usr/lib64/dnf5/plugins/changelog_cmd_plugin.so See https://stackoverflow.com/questions/7553184/how-to-do-versioning-of-shared-library This is something you should really do. This will also likely fix bunch or rpmlint errors perl5-libdnf5.x86_64: W: undefined-non-weak-symbol /usr/lib64/perl5/vendor_perl/auto/libdnf5/repo/repo.so .... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2120661 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
