https://bugzilla.redhat.com/show_bug.cgi?id=2128257 Vitaly Zaitsev <vitaly@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value Assignee|nobody@xxxxxxxxxxxxxxxxx |vitaly@xxxxxxxxxxxxxx Flags| |fedora-review? CC| |vitaly@xxxxxxxxxxxxxx --- Comment #1 from Vitaly Zaitsev <vitaly@xxxxxxxxxxxxxx> --- > # libmysqlclient-dev (>= 5.5.17-4), > # libpq-dev, > # libsdl1.2-dev, > # libv4l-dev, Can be removed. > Requires: libv4l Requires: libv4l%{?_isa} > Requires(post): systemd > Requires(preun): systemd > Requires(postun): systemd Should be replaced with %{?systemd_requires}. > Source0: https://github.com/Motion-Project/motion/archive/release-%{version}.tar.gz#/%{name}-release-%{version}.tar.gz Can be simplified: Source0: https://github.com/Motion-Project/motion/archive/release-%{version}/%{name}-release-%{version}.tar.gz > %triggerun -- motion < 3.3.0-trunkREV557.8 > find /var/motion -user root -group root -exec chown motion:video '{}' ';' This is too dangerous and should be removed. > %pre > getent passwd motion >/dev/null || \ > useradd -r -g video -d /run/motion -s /sbin/nologin \ > -c "motion detection system" motion > exit 0 Please switch to %sysusers_create_compat: https://docs.fedoraproject.org/en-US/packaging-guidelines/UsersAndGroups/ > %post > /usr/bin/systemd-tmpfiles --create %{_tmpfilesdir}/%{name}.conf Please switch to this: https://docs.fedoraproject.org/en-US/packaging-guidelines/Tmpfiles.d/ -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2128257 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
