https://bugzilla.redhat.com/show_bug.cgi?id=2115560 Petr Menšík <pemensik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value CC| |pemensik@xxxxxxxxxx --- Comment #1 from Petr Menšík <pemensik@xxxxxxxxxx> --- This package should run test, it has some present in sources. Therefore it should not be noarch package, but built separately for every platform. Also I think it should follow devel subpackages rule. Static library is a problem definitely. I guess it might provide libdxguid.so in a main package. Fedora requires all code libraries to be shared. It does not seem to me those guid list should be an exception. Though it does not add more additional code. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2115560 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue