https://bugzilla.redhat.com/show_bug.cgi?id=2127693 --- Comment #4 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- There are some warnings when running the tests, but they pass: + rspec -rtempfile -rjson spec/hashie spec/hashie_spec.rb /builddir/build/BUILD/hashie-5.0.0/usr/share/gems/gems/hashie-5.0.0/spec/hashie/ extensions/symbolize_keys_spec.rb:4: warning: method redefined; discarding old i nvoke /builddir/build/BUILD/hashie-5.0.0/usr/share/gems/gems/hashie-5.0.0/spec/hashie/ extensions/stringify_keys_spec.rb:4: warning: previous definition of invoke was here /builddir/build/BUILD/hashie-5.0.0/usr/share/gems/gems/hashie-5.0.0/lib/hashie/e xtensions/dash/property_translation.rb:132: warning: method redefined; discardin g old config= /builddir/build/BUILD/hashie-5.0.0/usr/share/gems/gems/hashie-5.0.0/lib/hashie/e xtensions/dash/property_translation.rb:132: warning: previous definition of conf ig= was here /builddir/build/BUILD/hashie-5.0.0/usr/share/gems/gems/hashie-5.0.0/lib/hashie/e xtensions/dash/property_translation.rb:132: warning: method redefined; discardin g old first_name= /builddir/build/BUILD/hashie-5.0.0/usr/share/gems/gems/hashie-5.0.0/lib/hashie/d ash.rb:99: warning: previous definition of first_name= was here ................................................................................ ................................................................................ ................................................................................ ........../builddir/build/BUILD/hashie-5.0.0/usr/share/gems/gems/hashie-5.0.0/sp ec/hashie/extensions/indifferent_access_spec.rb:124: warning: already initialize d constant ALIASES /builddir/build/BUILD/hashie-5.0.0/usr/share/gems/gems/hashie-5.0.0/spec/hashie/ extensions/indifferent_access_spec.rb:124: warning: previous definition of ALIAS ES was here ................................................................................ ...............W, [2022-09-19T08:24:37.285995 #1847] WARN -- : You are setting a key that conflicts with a built-in method #<Class:0x00007f73a9df7450>#foo defi ned at /builddir/build/BUILD/hashie-5.0.0/usr/share/gems/gems/hashie-5.0.0/spec/ hashie/extensions/mash/define_accessors_spec.rb:61. This can cause unexpected be havior when accessing the key as a property. You can still access the key via th e #[] method. ................................................................................ ................................................................................ ................................................................................ ................................................................................ ........................../builddir/build/BUILD/hashie-5.0.0/usr/share/gems/gems /hashie-5.0.0/lib/hashie/extensions/dash/property_translation.rb:132: warning: m ethod redefined; discarding old id= /builddir/build/BUILD/hashie-5.0.0/usr/share/gems/gems/hashie-5.0.0/lib/hashie/d ash.rb:99: warning: previous definition of id= was here .../builddir/build/BUILD/hashie-5.0.0/usr/share/gems/gems/hashie-5.0.0/lib/hashi e/extensions/dash/property_translation.rb:132: warning: method redefined; discar ding old id= /builddir/build/BUILD/hashie-5.0.0/usr/share/gems/gems/hashie-5.0.0/lib/hashie/d ash.rb:99: warning: previous definition of id= was here /builddir/build/BUILD/hashie-5.0.0/usr/share/gems/gems/hashie-5.0.0/lib/hashie/e xtensions/dash/property_translation.rb:132: warning: method redefined; discardin g old id= /builddir/build/BUILD/hashie-5.0.0/usr/share/gems/gems/hashie-5.0.0/lib/hashie/d ash.rb:99: warning: previous definition of id= was here ...... Finished in 0.96985 seconds (files took 1.25 seconds to load) 700 examples, 0 failures + rspec spec/integration/active_support ........................................................... Finished in 0.1166 seconds (files took 1.55 seconds to load) 59 examples, 0 failures + popd ~/build/BUILD/hashie-5.0.0 + RPM_EC=0 ++ jobs -p Processing files: rubygem-hashie-5.0.0-1.fc38.noarch + exit 0 Lint messages: $ rpmlint rubygem-hashie-5.0.0-1.fc38.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 rubygem-hashie.spec: W: invalid-url Source1: hashie-5.0.0-spec.tar.gz 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 1.9 s $ rpmlint rubygem-hashie-5.0.0-1.fc38.noarch.rpm ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 rubygem-hashie.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 16.8 s $ rpmlint rubygem-hashie-doc-5.0.0-1.fc38.noarch.rpm ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 4.0 s Comments: a) Should UPGRADING.md be placed in the documentation package? b) Can source1 be linked explicitly, it has a tag https://github.com/hashie/hashie/tags ? c) there are font files which should be packaged separately Lato-LightItalic.ttf Lato-RegularItalic.ttf SourceCodePro-Bold.ttf Lato-Light.ttf Lato-Regular.ttf SourceCodePro-Regular.ttf Corresponding packages https://packages.fedoraproject.org/pkgs/lato-fonts/lato-fonts/ https://packages.fedoraproject.org/pkgs/adobe-source-code-pro-fonts/adobe-source-code-pro-fonts/ Can make these packages dependencies and add softlinks at usr/share/gems/doc/hashie-5.0.0/rdoc/fonts d) Not sure why one still gets the warning [!]: When checking ruby code, install the ruby plugin. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2127693 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
