https://bugzilla.redhat.com/show_bug.cgi?id=2127737 Daniel Axelrod <fedora@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(ngompa13@xxxxxxxx | |m) --- Comment #4 from Daniel Axelrod <fedora@xxxxxxxxxxxxx> --- Thank you for the review! Please see updated files: Spec URL: https://download.copr.fedorainfracloud.org/results/packit/daxelrod-jowl-47/fedora-rawhide-x86_64/04844930-jowl/jowl.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/daxelrod-jowl-47/fedora-rawhide-x86_64/04844930-jowl/jowl-2.1.0-1.20220918210948584429.pr47.14.g1638749.fc38.src.rpm COPR build: https://copr.fedorainfracloud.org/coprs/packit/daxelrod-jowl-47/build/4844930/ (In reply to Neal Gompa from comment #3) > (In reply to Neal Gompa from comment #2) > > > > Issues: > > ======= > > - If (and only if) the source package includes the text of the license(s) > > in its own file, then that file, containing the text of the license(s) > > for the package is included in %license. > > Note: License file LICENSE-MIT is not marked as %license > > See: https://docs.fedoraproject.org/en-US/packaging- > > guidelines/LicensingGuidelines/#_license_text > > I'm pretty sure this is a misfire from the vendored node modules. Agree that this is a misfire. Spec includes %license LICENSE %{name}-%{version}-bundled-licenses.txt where LICENSE contains the text of theMIT license, and all prod dependencies' bundled licenses are also MIT. Do let me know if you need me to do anything to work around this. > > > - Sources used to build the package match the upstream source, as provided > > in the spec URL. > > Note: Upstream MD5sum check error, diff is in > > /home/ngompa/2127737-jowl/diff.txt > > See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ > > > > Here's the diff report: > > Only in > /home/ngompa/2127737-jowl/srpm-unpacked/jowl-2.1.0.tar.gz-extract/jowl-2.1.0: > dist > Only in > /home/ngompa/2127737-jowl/srpm-unpacked/jowl-2.1.0.tar.gz-extract/jowl-2.1.0: > .packit.yaml > > This is probably because you haven't merged your Packit PR and made a > release with it yet. Yes, exactly. I believe this is a bootstrapping problem where I need a tagged release with all files identical before this check can pass. After first creating this package, that will be my workflow anyway; dist-git will get updated after I cut a release upstream. For now, I'll solve this by addressing all other issues, and then cutting a new release, which should fix this one. > > jowl.noarch: W: files-duplicate /usr/lib/node_modules/jowl/jowl.js > > /usr/lib/node_modules/jowl/bin/jowl > > jowl.noarch: W: files-duplicate > > /usr/lib/node_modules/jowl/node_modules_prod/supports-color/license > > /usr/lib/node_modules/jowl/node_modules_prod/ansi-styles/license:/usr/lib/ > > node_modules/jowl/node_modules_prod/chalk/license:/usr/lib/node_modules/jowl/ > > node_modules_prod/has-flag/license > > jowl.noarch: W: files-duplicate > > /usr/lib/node_modules/jowl/node_modules_prod/lodash/fp/each.js > > /usr/lib/node_modules/jowl/node_modules_prod/lodash/each.js > > jowl.noarch: W: files-duplicate > > /usr/lib/node_modules/jowl/node_modules_prod/lodash/fp/eachRight.js > > /usr/lib/node_modules/jowl/node_modules_prod/lodash/eachRight.js > > jowl.noarch: W: files-duplicate > > /usr/lib/node_modules/jowl/node_modules_prod/lodash/fp/entries.js > > /usr/lib/node_modules/jowl/node_modules_prod/lodash/entries.js > > jowl.noarch: W: files-duplicate > > /usr/lib/node_modules/jowl/node_modules_prod/lodash/fp/entriesIn.js > > /usr/lib/node_modules/jowl/node_modules_prod/lodash/entriesIn.js > > jowl.noarch: W: files-duplicate > > /usr/lib/node_modules/jowl/node_modules_prod/lodash/fp/extend.js > > /usr/lib/node_modules/jowl/node_modules_prod/lodash/extend.js > > jowl.noarch: W: files-duplicate > > /usr/lib/node_modules/jowl/node_modules_prod/lodash/fp/extendWith.js > > /usr/lib/node_modules/jowl/node_modules_prod/lodash/extendWith.js > > jowl.noarch: W: files-duplicate > > /usr/lib/node_modules/jowl/node_modules_prod/lodash/fp/first.js > > /usr/lib/node_modules/jowl/node_modules_prod/lodash/first.js > > jowl.noarch: W: files-duplicate > > /usr/lib/node_modules/jowl/node_modules_prod/lodash/fp/assocPath.js > > /usr/lib/node_modules/jowl/node_modules_prod/lodash/fp/assoc.js > > jowl.noarch: W: files-duplicate > > /usr/lib/node_modules/jowl/node_modules_prod/lodash/fp/where.js > > /usr/lib/node_modules/jowl/node_modules_prod/lodash/fp/conforms.js > > jowl.noarch: W: files-duplicate > > /usr/lib/node_modules/jowl/node_modules_prod/lodash/fp/dissocPath.js > > /usr/lib/node_modules/jowl/node_modules_prod/lodash/fp/dissoc.js > > jowl.noarch: W: files-duplicate > > /usr/lib/node_modules/jowl/node_modules_prod/lodash/fp/whereEq.js > > /usr/lib/node_modules/jowl/node_modules_prod/lodash/fp/matches.js > > jowl.noarch: W: files-duplicate > > /usr/lib/node_modules/jowl/node_modules_prod/lodash/fp/property.js > > /usr/lib/node_modules/jowl/node_modules_prod/lodash/fp/path.js:/usr/lib/ > > node_modules/jowl/node_modules_prod/lodash/fp/prop.js > > jowl.noarch: W: files-duplicate > > /usr/lib/node_modules/jowl/node_modules_prod/lodash/fp/propEq.js > > /usr/lib/node_modules/jowl/node_modules_prod/lodash/fp/pathEq.js > > jowl.noarch: W: files-duplicate > > /usr/lib/node_modules/jowl/node_modules_prod/lodash/fp/propOr.js > > /usr/lib/node_modules/jowl/node_modules_prod/lodash/fp/pathOr.js > > jowl.noarch: W: files-duplicate > > /usr/lib/node_modules/jowl/node_modules_prod/lodash/fp/props.js > > /usr/lib/node_modules/jowl/node_modules_prod/lodash/fp/paths.js > > jowl.noarch: W: files-duplicate > > /usr/lib/node_modules/jowl/node_modules_prod/lodash/valueOf.js > > /usr/lib/node_modules/jowl/node_modules_prod/lodash/toJSON.js:/usr/lib/ > > node_modules/jowl/node_modules_prod/lodash/value.js > > To fix this, add the following: > > BuildRequires: fdupes > > and add "%fdupes %{buildroot}%{nodejs_sitelib}/%{name}" at the end of the > %install section. Done. > > jowl.noarch: W: dangling-relative-symlink > > /usr/lib/node_modules/jowl/node_modules/.bin ../node_modules_prod/.bin > > Uhhh? Good catch. This was caused by me copying the prep section from tape, whose prod node modules tarball has a .bin directory; but mine doesn't becuase none of Jowl's prod dependencies provide executables. Now fixed. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2127737 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
