https://bugzilla.redhat.com/show_bug.cgi?id=1187030 --- Comment #35 from Joachim Frieben <jfrieben@xxxxxxxxxxx> --- (In reply to Benson Muite from comment #34) Hi Benson, thanks for looking at my giza COPR package. Let me reply to your comments as follows: > 1) You have gcc-gfortran, but it would also be helpful to list gcc as a > build dependency The build requirement gcc-gfortran pulls in gcc already but I have added it explicitly in the latest build now in order to silence the package-review utility. > 2) Some of the comments on globbing of the filename seem not to have been > addressed. As an example see https://music.fedorapeople.org/20220607/libaiff.spec The suggested hack has been implemented but it breaks building the package for CentOS 7 whereas all other builds complete successfully. One could imagine a switch for CentOS but one might then simply stick to the previous expression, too. > 3) Perhaps also run the available tests Running 'make check' has been added. This option is actually implemented in the upstream package but it only compiles the test program and assumes that the user executes them individually and provides occasional user input. I had therefore left it out in the past but indeed checking for build failures is better than nothing. > 4) Provide a data subpackage I have split off the user documentation as recommended in the packaging guidelines. > 5) For your COPR builds, also enable AARCH64 and ARM-hfp to verify builds on > all supported architectures which are listed at > https://fedoraproject.org/wiki/Architectures#Primary_Architectures and > linked from https://docs.fedoraproject.org/en-US/packaging-guidelines/ > #_architecture_support I have enabled these additional build roots, and they do actually build successfully. > 6) Some of the files in the build directory have license GPLv3+ This merely seems to apply to some ancillary files used during the build process and which are part of autotools. According to the packaging guidelines they need not be taken into account. > 7) Fortran packaging mod files are architecture specific, see > https://docs.fedoraproject.org/en-US/packaging-guidelines/Fortran/ According to the packaging guidelines FORTRAN module files have to be installed in directory %{_fmoddir}. There are no further instructions for the multilib case which is a long-standing issue. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1187030 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
