[Bug 2070578] Review Request: python-sqladmin - SQLAdmin is a flexible Admin interface for SQLAlchemy models.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2070578

Jakub Kadlčík <jkadlcik@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value
                 CC|                            |jkadlcik@xxxxxxxxxx



--- Comment #1 from Jakub Kadlčík <jkadlcik@xxxxxxxxxx> ---
Hello Onuralp,
thank you for the package.


> Version:       0.1.7

There is already a 0.5.0 version on GitHub, can you please update?


> License:       MIT

I believe this is not true (anymore?). According to the pyproject.toml
and LICENSE.md, the project is available under a BSD license.


> %{?python_enable_dependency_generator}

I think this is the default, so this line can IMHO be deleted. Per

https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#Automatically-generated-dependencies

> In an emergency, you can opt-out from running the requires generator
> by adding %{?python_disable_dependency_generator} to the package
> (usually, just before the main package’s %description). 



> %description
> %{summary}.

Heh, I like the period at the end :D

Joking aside, please let's try to avoid duplicating the Summary. Can
you please write 2-3 sentences or points about the package?


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2070578
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux