[Bug 2126943] Review Request: perl-Template-Plugin-CGI - Simple Template Toolkit plugin interfacing to the CGI.pm module

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2126943



--- Comment #10 from Petr Pisar <ppisar@xxxxxxxxxx> ---
(In reply to Damian Wrobel from comment #6)
> (In reply to Petr Pisar from comment #1)
> 
> I'm in a process of fixing the issue and have the following doubts:
> 
> > FIX: Build-require 'perl(Template) >= 3.100' (t/cgi.t:21).
> This doesn't exist. dnf builddeps comlains:
> 
> No matching package to install: 'perl(Template) >= 3.100'
> 

It only exists in Fedora 38:

# dnf --quiet --enablerepo=f38-build repoquery --whatprovides 'perl(Template)
>= 3.100'
perl-Template-Toolkit-0:3.101-1.fc38.x86_64

> > FIX: Remove unused dependencies: perl(Carp), perl(CGI::Cookie),
> > perl(Template::Constants), perl(Test2::Bundle::Extended),
> > perl(Test2::Plugin::NoWarnings), perl(Test2::Suite),
> > perl(Test2::Tools::Explain), perl(Test::Builder), perl(Test::CPAN::Meta),
> > perl(Term::Cap), perl(Text::ParseWords).
> > Where did you get these dependencies from? I cannot see them used anywhere
> > in the code.
> 
> Test seems to require the following:
> # === Test Requires ===
> # 
> #     Module                     Want     Have
> #     ------------------------- ----- --------
> #     ExtUtils::MakeMaker         any     7.64
> #     File::Spec                  any     3.84
> #     File::Temp                  any   0.2311
> #     IO::Handle                  any     1.48
> #     IPC::Open3                  any     1.22
> #     Template                  3.100    3.101
> #     Test2::Bundle::Extended     any  missing <= you recommended to remove
> it
> #     Test2::Plugin::NoWarnings   any  missing <= you recommended to remove
> it
> #     Test2::Suite                any  missing <= you recommended to remove
> it
> #     Test2::Tools::Explain       any  missing <= you recommended to remove
> it
> #     Test::Builder               any 1.302191
> #     Test::CPAN::Meta            any  missing <= you recommended to remove
> it
> #     Test::More                  any 1.302191
> 
> So, It's probably good to keep them.

I think keeping them is not good. The modules are not used for anything except
of reporting their versions. E.g. look at Test2::Plugin::NoWarnings:

$ grep -Hnr Test2::Plugin::NoWarnings
cpanfile.plugins:11:        requires "Test2::Plugin::NoWarnings" => 0;
Makefile.PL:29:    "Test2::Plugin::NoWarnings" => 0,
Makefile.PL:52:  "Test2::Plugin::NoWarnings" => 0,
META.json:47:            "Test2::Plugin::NoWarnings" : "0",
META.yml:13:  Test2::Plugin::NoWarnings: '0'
cpanfile:11:        requires "Test2::Plugin::NoWarnings" => 0;
t/00-report-prereqs.dd:32:                                  
'Test2::Plugin::NoWarnings' => '0',

The first 6 locations are only a declaration of the dependency. A metadata. No
Code.
The last and the only location is an input for 00-report-prereqs.t which loads
the module only in order to print its version.
Therefore I conclude that it's better to remove them.

Theoretically it could be a plugin into tests whose mere presence causes its
load and use. But looking at its documentation
<https://metacpan.org/pod/Test2::Plugin::NoWarnings#SYNOPSIS> reveals it's not
that case. To use it you need to explicitly load it in a test. And as you can
see in the grep output, the module is never loaded.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2126943
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux