https://bugzilla.redhat.com/show_bug.cgi?id=2126943 --- Comment #7 from Damian Wrobel <dwrobel@xxxxxxxxxxxxxxxxxx> --- (In reply to Petr Pisar from comment #1) > URL and Source0 addresses are usable. Ok. > Source0 archive (SHA512: > 2ca0a9f0a72a2c26e73a5e7202ae3773349c032acc0c15b016a84e629fe326ac1fd53f45f0ffa > 6d23311bc1fa7f7ac1645df187373c59f5c6b1046985655d1cd) is original. Ok. > Summary verified from lib/Template/Plugin/CGI.pm. Ok. > TODO: I recommed spelling "the CGI.pm module" without the file name Done. > extension as "the CGI module". > > Description verified from lib/Template/Plugin/CGI.pm. Ok. > > FIX: The License is incomplete. Licenses found in the archive are: Done. > > lib/Template/Plugin/CGI.pm:11: GPL-1.0-or-later OR Artistic-1.0-Perl > /Tlibemplate/Plugin/CGI.pm:126: GPL-1.0-or-later OR Artistic-1.0-Perl > lib/Template/Plugin/CGI.pm:141: X11 > Makefile.PL:16: An unspecified MIT variant > LICENSE: MIT text. > > The license tag must comprehend all the licenses. > > The first two occurrences (GPL-1.0-or-later OR Artistic-1.0-Perl) must be > added. > Reading the POD, one can see doubled NAME and other sections. That's > probably a copy-and-paste mistake, but we need to respect all the licenses. > > The last three licenses are probably a sloppy expression for a single MIT > license <https://spdx.org/licenses/MIT.html> and author did not mean X11 > variant of MIT license <https://spdx.org/licenses/X11.html> as suggested at > lib/Template/Plugin/CGI.pm:141. > > Please change the License tag to "(GPL-1.0-or-later OR Artistic-1.0-Perl) > AND MIT" and contact upstream to clarify and preferably correct the mistakes. > > No XS code, noArch BuildArch is Ok. > > TODO: Qualify 'perl(ExtUtils::MakeMaker)' with >= '6.76' because of Done. > Makefile.PL arguments NO_PACKLIST=1 NO_PERLLOCAL=1. > FIX: Build-require 'perl(CGI) >= 4.44' (lib/Template/Plugin/CGI.pm:26, > META.json:32). > FIX: Build-require 'perl(strict)' (Makefile.PL:2). > FIX: Build-require 'perl(warnings)' (Makefile.PL:3). > FIX: Build-require 'perl(base)' (lib/Template/Plugin/CGI.pm:25). > FIX: Build-require 'perl(lib)' (t/cgi.t:20). > FIX: Build-require 'perl(Template) >= 3.100' (t/cgi.t:21). > FIX: Build-require 'perl(Template::Test)' (t/cgi.t:22). > > FIX: Remove unused dependencies: perl(Carp), perl(CGI::Cookie), > perl(CGI::File::Temp), perl(CGI::Util), perl(constant), perl(Cwd), > perl(Encode*, perl(Exporter), perl(Exporter::Heavy), perl(File::Path), > perl(File::Spec::Unix), perl(File::Temp), perl(HTML::Entities), > perl(HTML::Parser), perl(List::Util), perl(parent), perl(Scalar::Util), > perl(Socket), perl(Storable), perl(Template::Base), > perl(Template::Constants), perl(Test2::Bundle::Extended), > perl(Test2::Plugin::NoWarnings), perl(Test2::Suite), > perl(Test2::Tools::Explain), perl(Test::Builder), perl(Test::CPAN::Meta), > perl(Term::Cap), perl(Text::ParseWords). > Where did you get these dependencies from? I cannot see them used anywhere > in the code. > Done. With the exceptions aforementioned in #c6 > TODO: Unset AUTHOR_TESTING environment variable %check section to make the > tests more reproducible (t/author-pod-syntax.t:4). Done. > > FIX: The packeged module was part for perl-Template-Toolkit. You need to add > "Conflicts: perl-Template-Toolkit < 3.010-5" to prevent from installing both > of them at the same time. > Done. > Please correct the FIX items, consider fixing TODO items, and provide an > updated spec file. Please find updated files: Spec URL: https://dwrobel.fedorapeople.org/projects/rpmbuild/SPECS/perl-Template-Plugin-CGI.spec SRPM URL: https://dwrobel.fedorapeople.org/projects/rpmbuild/SRPMS/perl-Template-Plugin-CGI-3.101-2.fc38.src.rpm Fedora Review Log: https://download.copr.fedorainfracloud.org/results/dwrobel/perl-Template-Plugin-CGI/fedora-rawhide-x86_64/04838758-perl-Template-Plugin-CGI/fedora-review/review.txt Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=92042450 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2126943 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
