https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #7 from Renich Bon Ciric <renich@xxxxxxxxxxxxxxxx> --- OK, sorry for the delay. > a) Should the .sample files go in the documentation directory? OK, done. Moved all sample files to %{_docdir} as part of the main package (not the -doc package). > b) Might consider renaming > Source0: https://github.com/meetecho/janus-gateway/archive/refs/tags/v1.0.4.tar.gz > to > Source0: https://github.com/meetecho/%{name}/archive/v%{version}/%{name}_%{version}.tar.gz Done... somewhat. You suggested %{name}_%{version} but I used %{name}-%{version}. > c) May want to check codecs used are freely licensed I dunno if it uses codecs. Check out this FAQ: https://janus.conf.meetecho.com/docs/FAQ.html#transcoding. FAQ 13 and 14 say it doesn't use them. The plugins might. I'll check on those and report shortly. > d) Can one use the libraries independently of the application? If so, they should be in a subpackage: > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_library_or_application I wonder which libraries do youmean? Most .so components are just plugins, transports and event handlers for use of Janus. All that said for c) and d), I am unsure of my arguments so I will join their mailing list and ask about these two. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2121585 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
