https://bugzilla.redhat.com/show_bug.cgi?id=2116843 --- Comment #4 from Jakub Kadlčík <jkadlcik@xxxxxxxxxx> --- > I was able to get the tests working, but a test fixture is missing > from the PyPi package from upstream, so I had to skip some tests. Perfect, thank you very much! > # No tests provided by upstream. ð¢ That means this comment is not true. Can you please drop it / change it? At least the special characters are unnecessary > The test conditional (%if %{with tests}) was recommended by several > Python package maintainers and is in use with about 90+ Azure packages > so far. Okay, no problem here, thank you for the explanation :-) > Also, the description in the README talks mainly about Azure's > eventhub service capabilities and seems more like an advertisement. IDK, this doesn't seem a bad description to me: The Azure Event Hubs client library allows for publishing and consuming of Azure Event Hubs events and may be used to: - Emit telemetry about your application for business intelligence and diagnostic purposes. - Publish facts about the state of your application which interested parties may observe and use as a trigger for taking action. - Observe interesting operations and interactions happening within your business or other ecosystem, allowing loosely coupled systems to interact without the need to bind them together. - Receive events from one or more publishers, transform them to better meet the needs of your ecosystem, then publish the transformed events to a new stream for consumers to observe. ... As a person that knows nothing about Azure, I get the idea from it, what I could use the library for. We can have something entirely else for the description, I would just like to avoid copy-pasting the Summary. If you would like, can you write your own 2-3 sentences explaining the library? > As for the '/usr/lib/python3.11/site-packages/azure/' directory, this > is done via the pyproject macros automatically and it's in use with > the other Azure packages without issues. Ok, no problem here. > The pyproject macros automatically pull in the license into %files: > ❯ rpm -qlp python3-azure-eventhub-5.10.1-1.fc38.noarch.rpm | grep -i license > /usr/lib/python3.11/site-packages/azure_eventhub-5.10.1.dist-info/LICENSE That's true but per the pyproject-rpm-macros README https://src.fedoraproject.org/rpms/pyproject-rpm-macros > %pyproject_save_files can automatically mark license files with > %license macro [...] Only license files declared via PEP 639 > %License-File field are detected. Which is not the case for this package. We have only license='MIT License' field. So to be honest, I don't know if in this case we have to or don't have to use the %license macro manually. But since it's just one line, I would play it safe and use the %license macro. > I also updated to 5.10.1 Perfect, thank you. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2116843 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
