https://bugzilla.redhat.com/show_bug.cgi?id=2115150 --- Comment #14 from Alain V. <alain.vigne.14@xxxxxxxxx> --- (In reply to Jonathan Wright from comment #13) > @avigne (obfuscate my e-mail, please) can you finish the review on this? Working on it (don't know how to end testing your SRPM : mock --no-clean cherrytree-0.99.48-1.fc37.src.rpm does not have a /usr/bin/cherrytree when mock --shell :( https://fedoraproject.org/wiki/Using_Mock_to_test_package_builds is not very helpful. 1) I challenge your patch (Is this necessary ?) # add xml header to metainfo file Patch: metainfo_write.patch a- did you propose the patch upstream ? b- which tool is missing the XML header ? 2) It seems 7za is embedded (add_subdirectory(src/7za) in CMakeList) ? Would you mark this bundled() ? Can we bypass that ? Using Fedora p7zip is possible ? What is upstream position regarding embedding that piece of code ? 3) Licenses There are more licenses (Apache, BSD 3-Clause ..) due to the test suite (which is not activated, but you want that latter ?) Some LGPL v2 or later, LGPL v2.1 or later ... So, do you plan to extend the License field ? Licenses found: "Unknown or generated", "*No copyright* GNU General Public License v3.0 or later", "GNU General Public License v3.0 or later", "GNU Lesser General Public License v2.1 or later", "GNU Library General Public License v2 or later", "*No copyright* GNU General Public License, Version 3", "GNU Library General Public License v2 or later [generated file]", "GNU General Public License v2.0 or later", "MIT License", "BSD 3-Clause License", "*No copyright* BSD 3-Clause License", "Boost Software License 1.0", "*No copyright* Boost Software License 1.0", "*No copyright* MIT License", "*No copyright* Public domain", "*No copyright* GNU Lesser General Public License v2.1 or later", "BSD 3-Clause License [generated file]", "*No copyright* Apache License 2.0", "Apache License 2.0". 1390 files have unknown license. 4) Some diff in MD5sum check error ? @@ -1,5 +1,5 @@ -----BEGIN PGP PUBLIC KEY BLOCK----- Comment: Hostname: -Version: Hockeypuck 2.1.0-176-g9a9ef76 +Version: Hockeypuck 2.1.0-166-geb2a11b xsBNBFZ2sDoBCACj2ptGY7OSq3H2An2L03hjmwF05mXNkG8lF4drSEUpXGePs+sw -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2115150 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
